openstack/horizon
Code Issues Proposed changes
dc7d2582db
horizon/openstack_dashboard/enabled/_3020_identity_projects_panel.py

12 lines
481 B
Python
Raw Normal View History

Move Horizon to pure plugin loading only The root cause of 1479018 was the mixed method for loading content in horizon. This patch moves horizon to load purely from enabled files. There are a couple of things that were required to allow this change. 1) Adding a mechanism, can_register() to horizon/base.py to handle the configuration based loading checks that had been accumulating in the panel.py files. This is an optional static method in Panel to encapsulate such configuration (read settings) based panel loading logic. And added testing for and documentation for this addition. 2) Create a numbering scheme for plugins. Moved the base dashboards to _1000_project.py _2000_admin.py _3000_identity.py _5000_settings.py. then populated the required panel_group and panel enabled files sparsely in those ranges. The sparseness is to allow for future additions. Additionally, I moved the already added Angular based panels next to their Django counterparts. Once the configuration loading was normalized, the bug reported in 1479018 was resolved and tests work with plugins panels in all dashboards. Close-Bug: #1479018 Partially implements: blueprint plugin-sanity Change-Id: I657e7ce37b2593a901a859cebf3d6ff8ada91941
2015-08-03 14:23:42 -06:00
# The slug of the panel to be added to HORIZON_CONFIG. Required.
PANEL = 'projects'
# The slug of the dashboard the PANEL associated with. Required.
PANEL_DASHBOARD = 'identity'
Fix config ordering for identity plugin file The comment for DASHBOARD and GROUP config got switched. Change-Id: Ia5f2db2f2d91a7109b6b665ef272e5bd6c9962ca
2015-11-12 11:38:41 -08:00
# The slug of the panel group the PANEL is associated with.
PANEL_GROUP = 'default'
Set default panel of identity with pluggable settings mechanism The way of setting default panel of project dashboard and admin dashboard is the "pluggable settings" mechanism, but for identity dashboard, a traditional "hard-coded" way is used. It's a good idea to make it consistent with other dashboards. Change-Id: I52c584b5ef4981ede981385d39615ab8e7922abe Closes-Bug: #1717932
2017-09-18 06:54:25 -07:00
# If set, it will update the default panel of the PANEL_DASHBOARD.
DEFAULT_PANEL = 'projects'
Move Horizon to pure plugin loading only The root cause of 1479018 was the mixed method for loading content in horizon. This patch moves horizon to load purely from enabled files. There are a couple of things that were required to allow this change. 1) Adding a mechanism, can_register() to horizon/base.py to handle the configuration based loading checks that had been accumulating in the panel.py files. This is an optional static method in Panel to encapsulate such configuration (read settings) based panel loading logic. And added testing for and documentation for this addition. 2) Create a numbering scheme for plugins. Moved the base dashboards to _1000_project.py _2000_admin.py _3000_identity.py _5000_settings.py. then populated the required panel_group and panel enabled files sparsely in those ranges. The sparseness is to allow for future additions. Additionally, I moved the already added Angular based panels next to their Django counterparts. Once the configuration loading was normalized, the bug reported in 1479018 was resolved and tests work with plugins panels in all dashboards. Close-Bug: #1479018 Partially implements: blueprint plugin-sanity Change-Id: I657e7ce37b2593a901a859cebf3d6ff8ada91941
2015-08-03 14:23:42 -06:00
# Python panel class of the PANEL to be added.
ADD_PANEL = 'openstack_dashboard.dashboards.identity.projects.panel.Tenants'
Copy Permalink