openstack/horizon
Code Issues Proposed changes

Set the placeholder attribute in forms.py

Browse Source 
Closes-Bug: #1640059
Change-Id: I4428d4c6ef7c198b480595bda8e12d8794b25e8d
This commit is contained in:
Maxime Guyot 2016-11-08 08:09:53 +01:00
parent 0323f1fd17
commit 016724d4ed
2 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
horizon/static/horizon/js/horizon.forms.js
View File

@ -230,15 +230,6 @@ horizon.forms.add_password_fields_reveal_buttons = function (el) {
});
};
horizon.forms.init_examples = function (el) {
var $el = $(el);
// FIXME(gabriel): These should be moved into the forms themselves as help text, etc.
// Update/create image form.
$el.find("#create_image_form input#id_copy_from").attr("placeholder", "http://example.com/image.iso");
};
horizon.forms.init_themable_select = function ($elem) {
"use strict";
@ -348,9 +339,6 @@ horizon.addInitFunction(horizon.forms.init = function () {
horizon.forms.init_themable_select();
horizon.modals.addModalInitFunction(horizon.forms.init_themable_select);
horizon.forms.init_examples($body);
horizon.modals.addModalInitFunction(horizon.forms.init_examples);
horizon.forms.handle_snapshot_source();
horizon.forms.handle_volume_source();
horizon.forms.handle_image_source();

3
openstack_dashboard/dashboards/project/images/images/forms.py
View File

@ -125,7 +125,8 @@ class CreateImageForm(CreateParent):
'data-switch-on': 'source',
'data-source-url': _('Image Location'),
'ng-model': 'ctrl.copyFrom',
'ng-change': 'ctrl.selectImageFormat(ctrl.copyFrom)'
'ng-change': 'ctrl.selectImageFormat(ctrl.copyFrom)',
'placeholder': 'http://example.com/image.img'
}
image_url = ImageURLField(label=_("Image Location"),
help_text=_("An external (HTTP/HTTPS) URL to "