openstack/horizon
Code Issues Proposed changes

Fix intermittent integration test failures related to messages

Browse Source 
Some recent changes in python selenium bindings library made it do
certain things faster. That rendered our code for accessing Horizon
messages too restrictive, since it didn't wait a second. Previously,
when selenium queries took longer, the modal message had enough time
to appear, but now sometimes selenium is able to query the browser
during a narrow window when the spinner from a previous modal have
already disappeared, but the modal message still hasn't been
rendered. Adapt to these change by introducing a small (0.1 seconds)
margin to wait until message element appears.

Change-Id: I8f23ecaac9d007a1d3302eb9425d4064f438ca14
This commit is contained in:
Timur Sufiev 2016-08-25 13:44:59 +03:00
parent 28b6d6b30a
commit 02b9e2eb66
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack_dashboard/test/integration_tests/regions/messages.py
View File

@ -30,7 +30,7 @@ class MessageRegion(baseregion.BaseRegion):
self._default_src_locator = self._msg_locator(level)
# NOTE(tsufiev): we cannot use self._turn_off_implicit_wait() at this
# point, because the instance is not initialized by ancestor's __init__
driver.implicitly_wait(0)
driver.implicitly_wait(0.1)
try:
super(MessageRegion, self).__init__(driver, conf)
except NoSuchElementException: