From 0e518521c8e9b882e2fa778e46a11c6026f52eb7 Mon Sep 17 00:00:00 2001 From: Ivan Kolodyazhny Date: Thu, 2 May 2019 22:26:11 -0600 Subject: [PATCH] Remove ENABLE_FLAVOR_EDIT config option ENABLE_FLAVOR_EDIT is deprecated since Pike release and is not used anywhere. Change-Id: I06d5252c8f7bd955025587393f5d8ff00fe01c3b --- doc/source/configuration/settings.rst | 23 ------------------- .../management/commands/upgrade_check.py | 2 +- ...r-edit-config-option-0733b2ebb2ee1b4d.yaml | 4 ++++ 3 files changed, 5 insertions(+), 24 deletions(-) create mode 100644 releasenotes/notes/remove-enable-flavor-edit-config-option-0733b2ebb2ee1b4d.yaml diff --git a/doc/source/configuration/settings.rst b/doc/source/configuration/settings.rst index 268ea2ab4b..0a8c290512 100644 --- a/doc/source/configuration/settings.rst +++ b/doc/source/configuration/settings.rst @@ -2065,29 +2065,6 @@ This setting specifies the type of in-browser console used to access the VMs. Valid values are ``"AUTO"``, ``"VNC"``, ``"SPICE"``, ``"RDP"``, ``"SERIAL"``, ``"MKS"``, and ``None``. -ENABLE_FLAVOR_EDIT -~~~~~~~~~~~~~~~~~~ - -.. versionadded:: 12.0.0(Pike) - -.. deprecated:: 12.0.0(Pike) - -Default: ``False`` - -This setting enables the ability to edit flavors. - -.. warning:: - - Historically, Horizon has provided the ability to edit Flavors by deleting - and creating a new one with the same information. This is not supported in - the Nova API and causes unexpected issues and breakages. To avoid breaking - standard deprecation procedure, this code is still in Horizon, but disabled - by default. It will be removed during the 14.0.0 ('R') release cycle. - - See `this email thread - `_ - for further information. - INSTANCE_LOG_LENGTH ~~~~~~~~~~~~~~~~~~~ diff --git a/openstack_dashboard/management/commands/upgrade_check.py b/openstack_dashboard/management/commands/upgrade_check.py index 60e039f1a5..2aed3eb24d 100644 --- a/openstack_dashboard/management/commands/upgrade_check.py +++ b/openstack_dashboard/management/commands/upgrade_check.py @@ -166,7 +166,7 @@ def check_invalid_settings(dummy=None): @register_check(_("Deprecated Settings")) def check_deprecated_settings(dummy=None): - DEPRECATED_SETTINGS = {'ENABLE_FLAVOR_EDIT'} + DEPRECATED_SETTINGS = set() deprecated = [] for setting in dir(settings): if not setting.isupper() or setting.startswith("_"): diff --git a/releasenotes/notes/remove-enable-flavor-edit-config-option-0733b2ebb2ee1b4d.yaml b/releasenotes/notes/remove-enable-flavor-edit-config-option-0733b2ebb2ee1b4d.yaml new file mode 100644 index 0000000000..add741b522 --- /dev/null +++ b/releasenotes/notes/remove-enable-flavor-edit-config-option-0733b2ebb2ee1b4d.yaml @@ -0,0 +1,4 @@ +--- +upgrade: + - | + Deprecated config option ENABLE_FLAVOR_EDIT is removed.