openstack
/
horizon
Code Issues Proposed changes

Merge "trivial: Add TODOs for remaining function-based views"

This commit is contained in:
Zuul 2019-09-11 04:40:38 +00:00 committed by Gerrit Code Review
parent cfb907f803 ea24949ede
commit 10bb108cb8
4 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openstack_auth/views.py
View File

@ -50,6 +50,7 @@ except AttributeError:
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
# TODO(stephenfin): Migrate to CBV
@sensitive_post_parameters() @sensitive_post_parameters()
@csrf_protect @csrf_protect
@never_cache @never_cache
@ -152,6 +153,7 @@ def login(request):
return res return res
# TODO(stephenfin): Migrate to CBV
@sensitive_post_parameters() @sensitive_post_parameters()
@csrf_exempt @csrf_exempt
@never_cache @never_cache
@ -179,6 +181,7 @@ def websso(request):
return django_http.HttpResponseRedirect(settings.LOGIN_REDIRECT_URL) return django_http.HttpResponseRedirect(settings.LOGIN_REDIRECT_URL)
# TODO(stephenfin): Migrate to CBV
def logout(request, login_url=None, **kwargs): def logout(request, login_url=None, **kwargs):
"""Logs out the user if he is logged in. Then redirects to the log-in page. """Logs out the user if he is logged in. Then redirects to the log-in page.
@ -205,6 +208,7 @@ def logout(request, login_url=None, **kwargs):
**kwargs) **kwargs)
# TODO(stephenfin): Migrate to CBV
@login_required @login_required
def switch(request, tenant_id, redirect_field_name=auth.REDIRECT_FIELD_NAME): def switch(request, tenant_id, redirect_field_name=auth.REDIRECT_FIELD_NAME):
"""Switches an authenticated user from one project to another.""" """Switches an authenticated user from one project to another."""
@ -256,6 +260,7 @@ def switch(request, tenant_id, redirect_field_name=auth.REDIRECT_FIELD_NAME):
return response return response
# TODO(stephenfin): Migrate to CBV
@login_required @login_required
def switch_region(request, region_name, def switch_region(request, region_name,
redirect_field_name=auth.REDIRECT_FIELD_NAME): redirect_field_name=auth.REDIRECT_FIELD_NAME):
@ -279,6 +284,7 @@ def switch_region(request, region_name,
return response return response
# TODO(stephenfin): Migrate to CBV
@login_required @login_required
def switch_keystone_provider(request, keystone_provider=None, def switch_keystone_provider(request, keystone_provider=None,
redirect_field_name=auth.REDIRECT_FIELD_NAME): redirect_field_name=auth.REDIRECT_FIELD_NAME):

3
openstack_dashboard/dashboards/project/api_access/views.py
View File

@ -86,6 +86,7 @@ def _get_openrc_credentials(request):
} }
# TODO(stephenfin): Migrate to CBV
def download_ec2_bundle(request): def download_ec2_bundle(request):
tenant_name = request.user.tenant_name tenant_name = request.user.tenant_name
@ -118,6 +119,7 @@ def download_ec2_bundle(request):
return response return response
# TODO(stephenfin): Migrate to CBV
def download_rc_file(request): def download_rc_file(request):
template = settings.OPENRC_CUSTOM_TEMPLATE template = settings.OPENRC_CUSTOM_TEMPLATE
@ -137,6 +139,7 @@ def download_rc_file(request):
return _download_rc_file_for_template(request, context, template) return _download_rc_file_for_template(request, context, template)
# TODO(stephenfin): Migrate to CBV
def download_clouds_yaml_file(request): def download_clouds_yaml_file(request):
template = settings.OPENSTACK_CLOUDS_YAML_CUSTOM_TEMPLATE template = settings.OPENSTACK_CLOUDS_YAML_CUSTOM_TEMPLATE

6
openstack_dashboard/dashboards/project/instances/views.py
View File

@ -271,6 +271,7 @@ class LaunchInstanceView(workflows.WorkflowView):
return initial return initial
# TODO(stephenfin): Migrate to CBV
def console(request, instance_id): def console(request, instance_id):
data = _('Unable to get log for instance "%s".') % instance_id data = _('Unable to get log for instance "%s".') % instance_id
tail = request.GET.get('length') tail = request.GET.get('length')
@ -287,6 +288,7 @@ def console(request, instance_id):
return http.HttpResponse(data.encode('utf-8'), content_type='text/plain') return http.HttpResponse(data.encode('utf-8'), content_type='text/plain')
# TODO(stephenfin): Migrate to CBV
def auto_console(request, instance_id): def auto_console(request, instance_id):
console_type = settings.CONSOLE_TYPE console_type = settings.CONSOLE_TYPE
try: try:
@ -300,6 +302,7 @@ def auto_console(request, instance_id):
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)
# TODO(stephenfin): Migrate to CBV
def vnc(request, instance_id): def vnc(request, instance_id):
try: try:
instance = api.nova.server_get(request, instance_id) instance = api.nova.server_get(request, instance_id)
@ -311,6 +314,7 @@ def vnc(request, instance_id):
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)
# TODO(stephenfin): Migrate to CBV
def mks(request, instance_id): def mks(request, instance_id):
try: try:
instance = api.nova.server_get(request, instance_id) instance = api.nova.server_get(request, instance_id)
@ -322,6 +326,7 @@ def mks(request, instance_id):
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)
# TODO(stephenfin): Migrate to CBV
def spice(request, instance_id): def spice(request, instance_id):
try: try:
instance = api.nova.server_get(request, instance_id) instance = api.nova.server_get(request, instance_id)
@ -334,6 +339,7 @@ def spice(request, instance_id):
exceptions.handle(request, msg, redirect=redirect) exceptions.handle(request, msg, redirect=redirect)
# TODO(stephenfin): Migrate to CBV
def rdp(request, instance_id): def rdp(request, instance_id):
try: try:
instance = api.nova.server_get(request, instance_id) instance = api.nova.server_get(request, instance_id)

1
openstack_dashboard/views.py
View File

@ -40,6 +40,7 @@ def get_user_home(user):
return dashboard.get_absolute_url() return dashboard.get_absolute_url()
# TODO(stephenfin): Migrate to CBV
@django.views.decorators.vary.vary_on_cookie @django.views.decorators.vary.vary_on_cookie
def splash(request): def splash(request):
if not request.user.is_authenticated: if not request.user.is_authenticated: