openstack
/
horizon
Code Issues Proposed changes

Remove Description from Edit Image Metadata 

Image description can be edited through Edit Image -> Image Detail,
however it also appears as a property in Edit Image -> Metadata when
the description is not empty. It's confusing to have it in two sections
of one dialog form, and moreover, the Image Detail field always
overwrites the Metadata field.

This patch removes Description from Edit Metadata.

Closes-Bug: #2017698

Change-Id: I041948b4b71f00894f03cc30cfa4592df4a100c3
This commit is contained in:
Tatiana Ovchinnikova 2023-04-25 15:17:43 -05:00
parent 87b1455bfe
commit 283b38e4f1
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
horizon/static/framework/widgets/metadata/tree/metadata-tree-item.controller.js
View File

@ -17,6 +17,7 @@
'use strict';
var READONLY_PROPERTIES = ['os_hash_algo', 'os_hash_value'];
var DUPLICATE_PROPERTIES = ['description'];
angular
.module('horizon.framework.widgets.metadata.tree')
@ -41,6 +42,11 @@
ctrl.item.leaf.required = false;
}
if ('item' in ctrl && 'leaf' in ctrl.item &&
DUPLICATE_PROPERTIES.includes(ctrl.item.leaf.name)) {
delete ctrl.item;
}
if ('item' in ctrl && 'leaf' in ctrl.item && ctrl.item.leaf.type === 'array') {
ctrl.values = ctrl.item.leaf.items.enum.filter(filter).sort();