Merge "hacking: Specify white list rules in noqa explicity"

horizon/forms/__init__.py

@@ -16,10 +16,10 @@
 
 # FIXME(gabriel): Legacy imports for API compatibility.
 from django.core.exceptions import ValidationError
-from django.forms.fields import *  # noqa
-from django.forms.forms import *  # noqa
+from django.forms.fields import *  # noqa: F403,H303
+from django.forms.forms import *  # noqa: F403,H303
 from django.forms import widgets
-from django.forms.widgets import *  # noqa
+from django.forms.widgets import *  # noqa: F403,H303
 
 
 # Convenience imports for public API components.

horizon/test/tests/templatetags.py

@@ -25,10 +25,10 @@ from django.utils.text import normalize_newlines
 
 from horizon.test import helpers as test
 # The following imports are required to register the dashboards.
-from horizon.test.test_dashboards.cats.dashboard import Cats  # noqa
-from horizon.test.test_dashboards.cats.kittens.panel import Kittens  # noqa
-from horizon.test.test_dashboards.dogs.dashboard import Dogs  # noqa
-from horizon.test.test_dashboards.dogs.puppies.panel import Puppies  # noqa
+from horizon.test.test_dashboards.cats.dashboard import Cats  # noqa: F401
+from horizon.test.test_dashboards.cats.kittens.panel import Kittens  # noqa: F401
+from horizon.test.test_dashboards.dogs.dashboard import Dogs  # noqa: F401
+from horizon.test.test_dashboards.dogs.puppies.panel import Puppies  # noqa: F401
 
 
 def single_line(text):

horizon/test/tests/utils.py

@@ -23,7 +23,7 @@ from horizon import forms
 from horizon.test import helpers as test
 from horizon.utils import filters
 # we have to import the filter in order to register it
-from horizon.utils.filters import parse_isotime  # noqa
+from horizon.utils.filters import parse_isotime  # noqa: F401
 from horizon.utils import functions
 from horizon.utils import memoized
 from horizon.utils import secret_key

openstack_dashboard/api/rest/glance.py

@@ -88,7 +88,7 @@ class Image(generic.View):
     def delete(self, request, image_id):
         """Delete a specific image
 
-        DELETE http://localhost/api/glance/images/cc758c90-3d98-4ea1-af44-aab405c9c915  # noqa
+        DELETE http://localhost/api/glance/images/<image_id>
         """
         api.glance.image_delete(request, image_id)
 

openstack_dashboard/settings.py

@@ -316,7 +316,7 @@ OPENSTACK_PROFILER = {
 }
 
 try:
-    from local.local_settings import *  # noqa
+    from local.local_settings import *  # noqa: F403,H303
 except ImportError:
     logging.warning("No local_settings file found.")
 

openstack_dashboard/test/settings.py

@@ -14,7 +14,7 @@ import os
 import tempfile
 
 from django.utils.translation import pgettext_lazy
-from horizon.test.settings import *  # noqa
+from horizon.test.settings import *  # noqa: F403,H303
 from horizon.utils import secret_key
 from openstack_dashboard import exceptions
 

setup.py

@@ -20,7 +20,7 @@ import setuptools
 # setuptools if some other modules registered functions in `atexit`.
 # solution from: http://bugs.python.org/issue15881#msg170215
 try:
-    import multiprocessing  # noqa
+    import multiprocessing  # noqa: F401
 except ImportError:
     pass