openstack/horizon
Code Issues Proposed changes

ngTables should use themable checkboxes.

Browse Source 
This change makes ngimages and ngusers use the themable
checkboxes.

Change-Id: I2b577d17413bbbbe1a6e2671453f6510461c1b31
This commit is contained in:
Diana Whitten 2016-03-15 14:49:37 -07:00
parent bda5c01d45
commit 2994f6c2bf
2 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.html
View File

@ -25,7 +25,12 @@
Include action-col if you want to perform actions. Include action-col if you want to perform actions.
--> -->
<tr> <tr>
<th class="select-col"><input type="checkbox" hz-select-all="table.iusers"></th> <th class="select-col">
<div class="themable-checkbox">
<input id="users-select-col" type="checkbox" hz-select-all="table.iusers">
<label for="users-select-col"></label>
</div>
</th>
<th class="expander"></th> <th class="expander"></th>
<th class="rsp-p1" st-sort="name" st-sort-default="name" translate>User Name</th> <th class="rsp-p1" st-sort="name" st-sort-default="name" translate>User Name</th>
<th class="rsp-p2" st-sort="email" translate>Email</th> <th class="rsp-p2" st-sort="email" translate>Email</th>
@ -47,7 +52,10 @@
ng-class="{'st-selected': checked[user.id]}"> ng-class="{'st-selected': checked[user.id]}">
<td class="select-col"> <td class="select-col">
<input type="checkbox" ng-model="tCtrl.selections[user.id].checked" hz-select="user"> <div class="themable-checkbox">
<input id="user-{$ user.id $}" type="checkbox" ng-model="tCtrl.selections[user.id].checked" hz-select="user">
<label for="user-{$ user.id $}"></label>
</div>
</td> </td>
<td class="expander"> <td class="expander">
<span class="fa fa-chevron-right" hz-expand-detail duration="200"></span> <span class="fa fa-chevron-right" hz-expand-detail duration="200"></span>

9
openstack_dashboard/static/app/core/images/table/images-table.html
View File

@ -27,7 +27,10 @@
Include action-col if you want to perform actions. Include action-col if you want to perform actions.
--> -->
<th class="multi_select_column"> <th class="multi_select_column">
<input type="checkbox" hz-select-all="table.images"> <div class="themable-checkbox">
<input id="images-multi-select" type="checkbox" hz-select-all="table.images">
<label for="images-multi-select"></label>
</div>
</th> </th>
<th class="expander"></th> <th class="expander"></th>
@ -55,9 +58,13 @@
<tr ng-repeat-start="image in table.images track by image.id"> <tr ng-repeat-start="image in table.images track by image.id">
<td class="multi_select_column"> <td class="multi_select_column">
<div class="themable-checkbox">
<input type="checkbox" <input type="checkbox"
id="images-{$ image.id $}"
ng-model="tCtrl.selections[image.id].checked" ng-model="tCtrl.selections[image.id].checked"
hz-select="image"> hz-select="image">
<label for="images-{$ image.id $}"></label>
</div>
</td> </td>
<td class="expander"> <td class="expander">
<span class="fa fa-chevron-right" <span class="fa fa-chevron-right"