From 2fe3e92cd3b72de442ff003447dff2b8d07a185d Mon Sep 17 00:00:00 2001
From: Tatiana Ovchinnikova <t.v.ovtchinnikova@gmail.com>
Date: Thu, 3 Sep 2020 14:20:28 -0500
Subject: [PATCH] Make filters tests work

Filters JS tests have no output expectations but Jasmine Spec Runner marks
them 'passed' only adding "SPEC HAS NO EXPECTATIONS" into the tests names.
This patch adds expectations and fixes working tests.

Partial-Bug: #1894127

Change-Id: I8e434d03f80402cb4fabdffa7bfb1f2f6ddb379e
---
 .../framework/util/filters/filters.spec.js    | 23 ++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/horizon/static/framework/util/filters/filters.spec.js b/horizon/static/framework/util/filters/filters.spec.js
index a974f665a1..bbbcc48f3a 100644
--- a/horizon/static/framework/util/filters/filters.spec.js
+++ b/horizon/static/framework/util/filters/filters.spec.js
@@ -16,7 +16,16 @@
   'use strict';
 
   describe('horizon.framework.util.filters', function () {
+    var $httpBackend;
+    var testData = {timezone_dict: {
+      UTC: "+0000"
+    }};
+
     beforeEach(module('horizon.framework'));
+    beforeEach(inject(function (_$httpBackend_) {
+      $httpBackend = _$httpBackend_;
+      $httpBackend.expectGET('/api/timezones/').respond(testData);
+    }));
 
     describe('yesno', function () {
       var yesnoFilter;
@@ -58,6 +67,10 @@
         simpleDateFilter = _simpleDateFilter_;
       }));
 
+      afterEach(function () {
+        $httpBackend.flush();
+      });
+
       it('returns blank if nothing', function () {
         simpleDateFilter().then(getResult);
 
@@ -67,7 +80,7 @@
       });
 
       it('returns the expected time', function() {
-        simpleDateFilter().then(getResult);
+        simpleDateFilter('2019-09-03T09:19:07.000Z').then(getResult);
 
         function getResult(result) {
           expect(result).toBe('9/3/19 9:19 AM');
@@ -81,6 +94,10 @@
         mediumDateFilter = _mediumDateFilter_;
       }));
 
+      afterEach(function () {
+        $httpBackend.flush();
+      });
+
       it('returns blank if nothing', function () {
         mediumDateFilter().then(getResult);
 
@@ -90,7 +107,7 @@
       });
 
       it('returns the expected time', function() {
-        mediumDateFilter('2019-09-03T09:19:07.000').then(getResult);
+        mediumDateFilter('2019-09-03T09:19:07.000Z').then(getResult);
 
         function getResult(result) {
           expect(result).toBe('Sep 3, 2019 9:19:07 AM');
@@ -98,7 +115,7 @@
       });
 
       it('returns the expected time in UTC', function() {
-        mediumDateFilter('2019-09-03T09:19:07.000Z').then(getResult);
+        mediumDateFilter('2019-09-03T09:19:07.000').then(getResult);
 
         function getResult(result) {
           expect(result).toBe('Sep 3, 2019 9:19:07 AM');