From 31395b4d85db318c6e5f6b9c97b2b17bcc163268 Mon Sep 17 00:00:00 2001 From: pengyuesheng Date: Sun, 28 Apr 2019 10:44:26 +0800 Subject: [PATCH] Correct error messages on create rbac policy form The number of rbac policy reaches the maximum quota, when create rbac policy, an error message is shown and the error information is unclear. This patch correct the error message Change-Id: I2d8207ed1f87c2f604d4f3d2bf34f8214e785203 Closes-Bug: #1826693 --- openstack_dashboard/dashboards/admin/rbac_policies/forms.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/openstack_dashboard/dashboards/admin/rbac_policies/forms.py b/openstack_dashboard/dashboards/admin/rbac_policies/forms.py index 18b039806b..ad02a94747 100644 --- a/openstack_dashboard/dashboards/admin/rbac_policies/forms.py +++ b/openstack_dashboard/dashboards/admin/rbac_policies/forms.py @@ -15,6 +15,7 @@ import logging from django.urls import reverse from django.utils.translation import ugettext_lazy as _ +from neutronclient.common import exceptions as neutron_exc from horizon import exceptions from horizon import forms @@ -130,6 +131,10 @@ class CreatePolicyForm(forms.SelfHandlingForm): msg = _('RBAC Policy was successfully created.') messages.success(request, msg) return rbac_policy + except neutron_exc.OverQuotaClient: + redirect = reverse('horizon:admin:rbac_policies:index') + msg = _('rbac policy quota exceeded.') + exceptions.handle(request, msg, redirect=redirect) except Exception: redirect = reverse('horizon:admin:rbac_policies:index') msg = _('Failed to create a rbac policy.')