openstack/horizon
Code Issues Proposed changes

Replace filter() with a list-comprehension

Browse Source 
A list is expected, whereas filter() returns a generator on Python 3.

Partial-Implements: blueprint porting-python3
Change-Id: If3450c64c7ef086331b9a1d12d7d70b74260df60
This commit is contained in:
Victor Stinner 2015-07-13 13:44:48 +02:00
parent 750df2441e
commit 344100e1e4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstack_dashboard/test/test_data/utils.py
View File

@ -113,7 +113,8 @@ class TestDataContainer(object):
def get_match(obj):
return hasattr(obj, key) and getattr(obj, key) == value
return self.filter(filtered=filter(get_match, filtered), **kwargs)
filtered = [obj for obj in filtered if get_match(obj)]
return self.filter(filtered=filtered, **kwargs)
def get(self, **kwargs):
"""Returns the single object in this container whose attributes match