openstack
/
horizon
Code Issues Proposed changes

There is problem in UpdateRow of Horizon page. 

If we do some resource action(e.g. create/update/delete ...),
UpdateRow will be started.
And then resource status will be updated automatically in front-end.
But in case removing resource, number of resource that displayed
on both above and bottom of table will not be updated correctly.

I fixed update_footer_count function in horizon.tables.js.
This function only updates number of resource in footer field.
(tfoot span.table_count)
But we also need to update header field. (thead span.table_count)
So I add header update logic into this file.

Change-Id: Idc4330fe779b62607ada39a9db3637de82d014f7
Closes-Bug: #1694207
(cherry picked from commit 5b2fe409ed)
This commit is contained in:
Keiichi Hikita 2017-05-31 09:18:04 +09:00 committed by Rob Cresswell
parent 56810d347f
commit 352be501fc
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
horizon/static/horizon/js/horizon.tables.js
View File

@ -459,7 +459,7 @@ $.tablesorter.addParser({
horizon.datatables.update_footer_count = function (el, modifier) {
var $el = $(el),
$browser, $footer, row_count, footer_text_template, footer_text;
$browser, $header, $footer, row_count, footer_text_template, footer_text;
if (!modifier) {
modifier = 0;
}
@ -469,6 +469,7 @@ horizon.datatables.update_footer_count = function (el, modifier) {
$footer = $browser.find('.tfoot span.content_table_count');
}
else {
$header = $el.find('thead span.table_count');
$footer = $el.find('tfoot span.table_count');
}
row_count = $el.find('tbody tr:visible').length + modifier - $el.find('.empty').length;
@ -478,6 +479,7 @@ horizon.datatables.update_footer_count = function (el, modifier) {
} else {
footer_text = '';
}
$header.text(footer_text);
$footer.text(footer_text);
return row_count;
};