From 4a89303231bbb00af25064912091516b07ba754e Mon Sep 17 00:00:00 2001 From: Radomir Dopieralski Date: Tue, 4 Apr 2023 17:35:30 +0200 Subject: [PATCH] Clean up the syntax of html attributes to always use double quotes Our templates are very inconsistent and sometimes even use single and double quotes in the same tag. This is an attempt to clean it up a little and use double quotes everywhere. In addition, I have run into a problem with single quotes being incorrectly escaped by the Django compressor, and I want to see if this will help with the issue. Change-Id: I2d5137a87ed65c6abef38a49264346f917a1c85a --- .../widgets/headers/hz-page-header.html | 4 +- .../widgets/metadata/tree/metadata-tree.html | 2 +- .../property/hz-resource-property.html | 2 +- horizon/templates/horizon/_nav_list.html | 2 +- horizon/templates/horizon/_subnav_list.html | 2 +- .../templates/horizon/client_side/_modal.html | 12 ++-- .../templates/horizon/common/_data_table.html | 2 +- .../common/_data_table_row_action_row.html | 2 +- .../templates/horizon/common/_datepicker.html | 2 +- .../horizon/common/_detail_header.html | 4 +- .../horizon/common/_domain_page_header.html | 2 +- .../templates/horizon/common/_form_field.html | 4 +- .../horizon/common/_page_header.html | 4 +- .../templates/horizon/common/_sidebar.html | 2 +- .../templates/horizon/common/_tab_group.html | 2 +- .../templates/horizon/jasmine/jasmine.html | 4 +- .../horizon/jasmine/jasmine_legacy.html | 24 +++---- horizon/test/templates/base.html | 16 ++--- horizon/test/unit/tables/test_tables.py | 4 +- .../unit/templatetags/test_templatetags.py | 6 +- .../theme-preview/theme-preview.html | 2 +- .../templates/instances/_detail_console.html | 2 +- .../templates/instances/_instance_flavor.html | 4 +- .../network_topology/_graph_view.html | 2 +- .../network_topology/_post_massage.html | 2 +- .../network_topology/_svg_element.html | 4 +- .../templates/network_topology/iframe.html | 4 +- .../launch-instance/keypair/keypair.html | 2 +- .../launch-instance/source/source.html | 2 +- openstack_dashboard/templates/500.html | 2 +- .../templates/_stylesheets.html | 4 +- .../templates/angular/angular_templates.html | 2 +- openstack_dashboard/templates/base.html | 14 ++-- .../context_selection/_anti_clickjack.html | 2 +- .../templates/horizon/_conf.html | 6 +- .../templates/horizon/_scripts.html | 64 +++++++++---------- .../templates/serial_console.html | 10 +-- .../themes/example/templates/base.html | 4 +- .../material/templates/header/_header.html | 2 +- 39 files changed, 118 insertions(+), 118 deletions(-) diff --git a/horizon/static/framework/widgets/headers/hz-page-header.html b/horizon/static/framework/widgets/headers/hz-page-header.html index 4b586cf9a7..0172f7128b 100644 --- a/horizon/static/framework/widgets/headers/hz-page-header.html +++ b/horizon/static/framework/widgets/headers/hz-page-header.html @@ -1,5 +1,5 @@ - diff --git a/horizon/static/framework/widgets/metadata/tree/metadata-tree.html b/horizon/static/framework/widgets/metadata/tree/metadata-tree.html index 185c813469..48263059e3 100644 --- a/horizon/static/framework/widgets/metadata/tree/metadata-tree.html +++ b/horizon/static/framework/widgets/metadata/tree/metadata-tree.html @@ -34,7 +34,7 @@ ng-model="ctrl.customItem" validate-unique="ctrl.checkNameUnique"/> - {% else %} - + {% if action.icon != None %} {% endif %} {{ action.verbose_name }} diff --git a/horizon/templates/horizon/common/_datepicker.html b/horizon/templates/horizon/common/_datepicker.html index efac7fdd91..5073761925 100644 --- a/horizon/templates/horizon/common/_datepicker.html +++ b/horizon/templates/horizon/common/_datepicker.html @@ -1,7 +1,7 @@ {% load i18n %} {% block trimmed %} -
+
{{ datepicker_input }} diff --git a/horizon/templates/horizon/common/_detail_header.html b/horizon/templates/horizon/common/_detail_header.html index be12cb65fc..db99156f95 100644 --- a/horizon/templates/horizon/common/_detail_header.html +++ b/horizon/templates/horizon/common/_detail_header.html @@ -1,4 +1,4 @@ -