openstack
/
horizon
Code Issues Proposed changes

Allow Jasmine failures to fail test 

There was a selector bug that caused the Jasmine helper to not find
failures in Jasmine tests.  The selectors are now fixed.

Change-Id: I2f66f4b04cd6e9fc1f7259bdac351ac0fe87e23c
Closes-Bug: 1421788
This commit is contained in:
Matt Borland 2015-03-03 10:22:41 -07:00
parent 2382c2df2d
commit 4d8777bff9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
horizon/test/helpers.py
View File

@ -284,14 +284,14 @@ class JasmineTests(SeleniumTestCase):
wait.until(jasmine_done)
failures = \
self.selenium.find_elements_by_css_selector(".specDetail.failed")
self.selenium.find_elements_by_css_selector(".spec-detail.failed")
results = []
for failure in failures:
results.append(
failure.find_element_by_class_name("description").text)
results.append(
failure.find_element_by_class_name("stackTrace").text)
failure.find_element_by_class_name("stack-trace").text)
self.assertEqual(results, [], '\n\n' + '\n\n'.join(results) + '\n\n')