From 5d6fe4b05f5ee768d353f02ccbe396491ac27135 Mon Sep 17 00:00:00 2001 From: Alessandro Pilotti Date: Tue, 11 Mar 2014 21:14:34 +0200 Subject: [PATCH] Disables the clear text password UI by default The old way of assigning passwords in clear text to instances has been superseded by the nova get-password feature. A corresponding UI feature has been recently included in Horizon (see blueprint "decrypt-and-display-vm-generated-password"). This commit disables the visualization of the old password UI by default. Change-Id: Ia9a8b5c1c398054fb3d726b93f7fecc332b02efe Closes-bug: #1291006 --- doc/source/topics/settings.rst | 4 ++-- openstack_dashboard/api/nova.py | 2 +- openstack_dashboard/local/local_settings.py.example | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/source/topics/settings.rst b/doc/source/topics/settings.rst index 0ace301670..068e77f87b 100644 --- a/doc/source/topics/settings.rst +++ b/doc/source/topics/settings.rst @@ -251,7 +251,7 @@ Default:: { 'can_set_mount_point': False, - 'can_set_password': True + 'can_set_password': False } A dictionary containing settings which can be used to identify the @@ -262,7 +262,7 @@ to instances (other Hypervisors currently do not). Setting ``can_set_mount_point`` to ``True`` will add the option to set the mount point from the UI. -Setting ``can_set_password`` to ``False`` will remove the option to set +Setting ``can_set_password`` to ``True`` will enable the option to set an administrator password when launching or rebuilding an instance. diff --git a/openstack_dashboard/api/nova.py b/openstack_dashboard/api/nova.py index cb22a87819..feb85eaf7b 100644 --- a/openstack_dashboard/api/nova.py +++ b/openstack_dashboard/api/nova.py @@ -762,4 +762,4 @@ def extension_supported(extension_name, request): def can_set_server_password(): features = getattr(settings, 'OPENSTACK_HYPERVISOR_FEATURES', {}) - return features.get('can_set_password', True) + return features.get('can_set_password', False) diff --git a/openstack_dashboard/local/local_settings.py.example b/openstack_dashboard/local/local_settings.py.example index 53b52c0e5b..74f7bf8357 100644 --- a/openstack_dashboard/local/local_settings.py.example +++ b/openstack_dashboard/local/local_settings.py.example @@ -160,7 +160,7 @@ OPENSTACK_KEYSTONE_BACKEND = { # from the UI. OPENSTACK_HYPERVISOR_FEATURES = { 'can_set_mount_point': False, - 'can_set_password': True, + 'can_set_password': False, } # The OPENSTACK_NEUTRON_NETWORK settings can be used to enable optional