openstack/horizon
Code Issues Proposed changes

Trunks panel: improve details' test coverage

Browse Source 
Change-Id: Iad10b17f854aec4d3227fc0b4aba6f4c781f95f1
This commit is contained in:
Bence Romsics 2017-07-28 11:39:58 +02:00
parent bf90f17067
commit 6642d6e0da
1 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
openstack_dashboard/static/app/core/trunks/trunks.service.spec.js
View File

@ -15,19 +15,21 @@
*/ */
(function() { (function() {
"use strict"; 'use strict';
describe('trunks service', function() { describe('trunks service', function() {
var service; var service, _location_;
beforeEach(module('horizon.framework.util')); beforeEach(module('horizon.framework.util'));
beforeEach(module('horizon.framework.conf')); beforeEach(module('horizon.framework.conf'));
beforeEach(module('horizon.app.core.trunks')); beforeEach(module('horizon.app.core.trunks'));
beforeEach(inject(function($injector) { beforeEach(inject(function($injector, $location) {
service = $injector.get('horizon.app.core.trunks.service'); service = $injector.get('horizon.app.core.trunks.service');
_location_ = $location;
})); }));
describe('getTrunkPromise', function() { describe('getTrunkPromise', function() {
it("provides a promise", inject(function($q, $injector, $timeout) { it('provides a promise', inject(function($q, $injector, $timeout) {
var neutron = $injector.get('horizon.app.core.openstack-service-api.neutron'); var neutron = $injector.get('horizon.app.core.openstack-service-api.neutron');
var deferred = $q.defer(); var deferred = $q.defer();
spyOn(neutron, 'getTrunk').and.returnValue(deferred.promise); spyOn(neutron, 'getTrunk').and.returnValue(deferred.promise);
@ -37,10 +39,20 @@
expect(neutron.getTrunk).toHaveBeenCalled(); expect(neutron.getTrunk).toHaveBeenCalled();
expect(result.$$state.value.data.updated_at).toBe('May29'); expect(result.$$state.value.data.updated_at).toBe('May29');
})); }));
});
describe('getTrunksPromise', function() { it('redirects back to panel on failure', inject(function($q, $injector, $timeout) {
it("provides a promise that gets translated", inject(function($q, $injector, $timeout) { var neutron = $injector.get('horizon.app.core.openstack-service-api.neutron');
var deferred = $q.defer();
spyOn(neutron, 'getTrunk').and.returnValue(deferred.promise);
spyOn(_location_, 'url');
service.getTrunkPromise({});
deferred.reject();
$timeout.flush();
expect(neutron.getTrunk).toHaveBeenCalled();
expect(_location_.url).toHaveBeenCalledWith('project/trunks');
}));
it('provides a promise that gets translated', inject(function($q, $injector, $timeout) {
var neutron = $injector.get('horizon.app.core.openstack-service-api.neutron'); var neutron = $injector.get('horizon.app.core.openstack-service-api.neutron');
var session = $injector.get('horizon.app.core.openstack-service-api.userSession'); var session = $injector.get('horizon.app.core.openstack-service-api.userSession');
var deferred = $q.defer(); var deferred = $q.defer();
@ -55,6 +67,7 @@
expect(result.$$state.value.data.items[0].updated_at).toBe('Apr10'); expect(result.$$state.value.data.items[0].updated_at).toBe('Apr10');
expect(result.$$state.value.data.items[0].id).toBe(1); expect(result.$$state.value.data.items[0].id).toBe(1);
})); }));
}); });
}); });