openstack
/
horizon
Code Issues Proposed changes

Merge "Implement 'selector-append' sass function" into stable/stein

This commit is contained in:
Zuul 2020-04-27 16:06:04 +00:00 committed by Gerrit Code Review
parent 5b9655153b d4028b97db
commit 6b32ff44ea
2 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
openstack_dashboard/themes/material/static/horizon/_styles.scss
View File

@ -1,3 +1,12 @@
// NOTE(e0ne): it's temporary workaround to until specified function will
// be supported by pyScss. We need to define this function before any MDI
// usage.
@if not function-exists("selector-append") {
@function selector-append($selector, $to-append) {
@return append-selector($selector, $to-append);
}
}
@import "animations";
@import "icons";
@import "components/checkboxes";

12
releasenotes/notes/pyscss-and-setuptools-7634dcee9d62bde9.yaml
View File

@ -1,13 +1,9 @@
---
issues:
- |
The material design theme is now broken with pyScss 1.3.7
(also see the upgrade notice section).
If you really depends on the material design theme, keep using
pyScss 1.3.4 with setuptools<45 (while the horizon dependencies list
says pyScss>=1.3.7 is required).
The issue is tracked via [:bug:`1771559`].
upgrade:
- |
pyScss 1.3.7 is now required due to the incompatibility that
pyScss 1.3.4 used before in horizon does not work with setuptools 46.
- |
Along with the upgrade of pyScss to 1.3.7, a workaround for the
material design theme is added to make it work properly.
See [:bug:`1771559`] for detail.