openstack/horizon
Code Issues Proposed changes

fix(swift): allow object creation

Browse Source 
It is currently not possible to create any new objects inside
Swift as you'd always get an error that the new object name
already exists all the time.

This fixes that issue and enables you to upload files again.

Closes-Bug: #1993005
Related-Change-Id: Idfb90a327e94ccaa3263aaaad1d6d52fa46312f4
Change-Id: Ib2f1aaae87820e8d5c4a6c9b01b6a6e9a5552952
(cherry picked from commit a327842a25)
This commit is contained in:
Mohammed Naser 2023-02-19 18:47:11 +00:00 committed by Dr. Jens Harbott
parent 3dd3d4ffe0
commit 858d4790cf
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstack_dashboard/static/app/core/openstack-service-api/swift.service.js
View File

@ -296,8 +296,7 @@
service.getObjectURL(container, objectName, 'metadata') service.getObjectURL(container, objectName, 'metadata')
); );
if (ignoreError) { if (ignoreError) {
// provide a noop error handler so the error is ignored return promise;
return promise.catch(angular.noop);
} }
return promise.catch(function onError() { return promise.catch(function onError() {
toastService.add('error', gettext('Unable to get details of the object.')); toastService.add('error', gettext('Unable to get details of the object.'));

1
openstack_dashboard/static/app/core/openstack-service-api/swift.service.spec.js
View File

@ -256,7 +256,6 @@
spyOn(promise, 'catch'); spyOn(promise, 'catch');
spyOn(toastService, 'add'); spyOn(toastService, 'add');
service.getObjectDetails('spam', 'ham', true); service.getObjectDetails('spam', 'ham', true);
expect(promise.catch).toHaveBeenCalledWith(angular.noop);
expect(toastService.add).not.toHaveBeenCalled(); expect(toastService.add).not.toHaveBeenCalled();
}); });