openstack
/
horizon
Code Issues Proposed changes

Initial Clean Up Old Styles in _debt.scss 

Unnecessary Styles:
 * #create_container_form .modal-footer
 * .list-bullet
 * dt

Can't find usage:
 * .btn-inline
 * #actions.single
 * div.input input[type="checkbox"]
 * .item_detail

Not used any longer:
 * .modal-body fieldset .form-field select[data-add-item-url

Change-Id: Ibfeeec84a58d4dffaa669fc48f27cac02a2011c7
Partially-implements: blueprint horizon-theme-css-reorg
This commit is contained in:
Diana Whitten 2016-03-15 15:32:39 -07:00
parent 504885d6df
commit 8b76b5fb90
4 changed files with 19 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
openstack_dashboard/static/dashboard/scss/_debt.scss
View File

@ -1,51 +1,20 @@
/* The styles in this file need to be researched and/or removed when possible */
#create_container_form .modal-footer {
margin-top: 190px;
}
#usage {
margin-bottom: 25px;
height: 125px;
}
#actions.single {
width: 90px;
}
ul {
list-style: none;
margin: 0;
}
// Disc-styled list. This list should be used to build bullet-items lists.
.list-bullet {
list-style: disc;
}
dt {
font-weight: bold;
}
.static_page {
float: left; //should be removed (jtomasek)
background-color: $body-bg; //should be removed (jtomasek)
> form {
margin-bottom: 0;
}
}
// should be removed and replaced by row + col-sm-6 in template
.left, .right {
@extend .col-sm-6;
}
// Fixes issue with bootstrap positioning of modal container
// Note (hurgleburgler) Is this really still an issue? Further research needed
.modal {
top: 0 !important;
}
.dynamic-error {
background: $body-bg;
border: 1px solid $border-color;
@ -53,15 +22,6 @@ dt {
margin-bottom: 0.5em;
}
/* Styling for inline object creation buttons */
.btn-inline {
margin-bottom: 9px;
}
.modal-body fieldset .form-field select[data-add-item-url] {
width: 275px;
margin-right: 2px;
}
/* Styling for draged network object */
#networkListSortContainer {
display: none;
@ -165,33 +125,12 @@ dt {
background:transparent;
}
}
}
div.input input[type="checkbox"] {
float: left;
width: 25px;
}
.javascript_disabled_alert {
@extend .alert-danger;
border-bottom-style: solid;
border-bottom-width: 1px;
padding: 8px;
text-align: center;
}
iframe {
border: none;
}
.item_detail ul li label {
color: $text-color;
font-weight: bold;
display: block;
margin-top: 5px;
}
.progress_bar {
height: 100%;
width: 100%;
@ -218,14 +157,6 @@ iframe {
background-color: $brand-danger;
}
/* Fix for password fields reveal icon */
.form-group span.form-control-feedback.fa {
line-height: 32px;
}
.has-feedback .form-control-feedback {
top: 0;
}
/* ============ */
/* Known issues */
/* ============ */

14
openstack_dashboard/static/dashboard/scss/components/_forms.scss
View File

@ -1,5 +1,13 @@
/**** Prevent long image names from breaking form layout in Firefox ****/
.form-group input[type="file"] {
width: 100%;
white-space: normal;
.form-group {
input[type="file"] {
width: 100%;
white-space: normal;
}
/* Fix for input icon alignment */
input + .fa {
line-height: $input-height-base;
top: 0;
}
}

7
openstack_dashboard/static/dashboard/scss/components/_messages.scss
View File

@ -23,6 +23,13 @@
}
}
.javascript-disabled {
margin-top: $navbar-height;
width: 100%;
position: absolute;
z-index: 1;
}
.alert > ul {
padding: 0;
}

2
openstack_dashboard/templates/base.html
View File

@ -19,7 +19,7 @@
</head>
<body id="{% block body_id %}{% endblock %}" ng-app='horizon.app' ng-strict-di>
<noscript>
<div class="javascript_disabled_alert">
<div class="alert alert-danger text-center javascript-disabled">
{% trans "This application requires JavaScript to be enabled in your web browser." %}
</div>
</noscript>