openstack
/
horizon
Code Issues Proposed changes

Remove obsolete creation_counter field 

creation_counter is never used in fields.py and was deprecated in
Django 2.x. Fields of object are keeped internally as ordered
dictionary, so we don't need any additional tools to manage it

Related Django bug:
https://code.djangoproject.com/ticket/23919#comment:95

Change-Id: I530a47ad8bfed6aef63d0a678a69fa09288f123e
This commit is contained in:
BubaVV 2019-02-05 17:54:13 +02:00 committed by Vadym Markov
parent a7266479b2
commit 8ccbd83577
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
horizon/forms/fields.py
View File

@ -640,7 +640,6 @@ class ExternalUploadMeta(forms.DeclarativeFieldsMetaclass):
if isinstance(attr, ExternalFileField):
hidden_field = fields.CharField(widget=fields.HiddenInput,
required=False)
hidden_field.creation_counter = attr.creation_counter + 1000
new_attr_name = get_double_name(attr_name)
new_attrs[new_attr_name] = hidden_field
meth_name = 'clean_' + new_attr_name