openstack/horizon
Code Issues Proposed changes

Remove old trans filter

Browse Source 
Once we make the move to angular-gettext, we will not longer need the
trans filter. Since we are not using it anywhere, we can safely remove it now,
and ensure that there will be no future conflict.

Change-Id: Id31a820db9e984e7851c0481ec65195a53a0255e
Closes-bug: #1472447
This commit is contained in:
Thai Tran 2015-07-07 18:14:28 -07:00
parent 84aae88057
commit 8e3a873c90
2 changed files with 3 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
horizon/static/framework/util/filters/filters.js
View File

@ -163,18 +163,6 @@
var format = ngettext('Displaying %s item', 'Displaying %s items', count);
return interpolate(format, [count]);
};
})
});
/**
* @ngdoc filter
* @name trans
* @description
* Returns translated text.
*/
.filter('trans', ['horizon.framework.util.i18n.gettext', function (gettextFunc) {
return function (input) {
// NOTE: uses 'gettextFunc' to avoid message collection.
return gettextFunc(input);
};
}]);
}());

9
horizon/static/framework/util/filters/filters.spec.js
View File

@ -202,10 +202,5 @@
);
});
describe('trans', function () {
it('should return translated text', inject(function (transFilter) {
expect(transFilter("Howdy")).toBe("Howdy");
}));
});
});
})();
}); // end of horizon.framework.util.filters
})(); // end of IIFE