From 93c4ded713c23832237f2c30974e0566574b8134 Mon Sep 17 00:00:00 2001 From: Gloria Gu Date: Fri, 30 Aug 2019 13:47:39 -0700 Subject: [PATCH] Remove the check which causes plugin's quotas update failure The check causes external plugin's quotas fields unknown exception because the quotas fields are not part of QUOTA_FIELDS which only includes the fields for cinder, neutron and nova. Meanwhile the exception message throws TypeError. This commit removes the uncessary check. It also helps fix the manila-ui's bug #1842119 Change-Id: If093f4ecf1e344792b347c5c338b441b1ab42a04 Closes-bug: #1798048 Closes-bug: #1842119 (cherry picked from commit 44987f02be671fd81b3dcd8d22f9fa1b219488c2) (cherry picked from commit be4d2301bb9654a772990d5d6f7bb2b126c7c127) --- openstack_dashboard/usage/quotas.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/openstack_dashboard/usage/quotas.py b/openstack_dashboard/usage/quotas.py index f60cb1399e..731ad4ee72 100644 --- a/openstack_dashboard/usage/quotas.py +++ b/openstack_dashboard/usage/quotas.py @@ -238,9 +238,6 @@ def get_tenant_quota_data(request, disabled_quotas=None, tenant_id=None): @profiler.trace def get_disabled_quotas(request, targets=None): if targets: - if set(targets) - QUOTA_FIELDS: - raise ValueError('Unknown quota field names are included: %s' - % set(targets) - QUOTA_FIELDS) candidates = set(targets) else: candidates = QUOTA_FIELDS