openstack/horizon
Code Issues Proposed changes

bump eslint version to 1.10.3

Browse Source 
bumps the eslint version to 1.10.3 which fixes a lot of
issues, especially rules not working as expected
or being ignored and brings the js code up to date to
comply with those rules.

Change-Id: I1234e7991f98d4ceb0c5333dc036c6a30206ff64
This commit is contained in:
Itxaka 2016-02-19 10:41:34 +01:00 committed by Itxaka Serrano Garcia
parent e1f07e2794
commit 9697a9f580
12 changed files with 61 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.eslintignore
View File

@ -1 +1 @@
horizon/static/horizon/lib/
horizon/static/horizon/lib/**

6
horizon/static/auth/login/login.spec.js
View File

@ -43,9 +43,9 @@
var pass = actual.css('display') !== 'none';
var result = {
pass: pass,
message: pass ?
'Expected element to be visible' :
'Expected element to be visible, but it is hidden'
message: pass
? 'Expected element to be visible'
: 'Expected element to be visible, but it is hidden'
};
return result;
}

6
horizon/static/framework/util/promise-toggle/hz-promise-toggle.directive.js
View File

@ -114,9 +114,9 @@
function resolvePromises(scope, iterStartElement) {
var resolvedInput = input(scope);
var promiseResolver = angular.isArray(resolvedInput) ?
multiPromiseResolver(singlePromiseResolver, resolvedInput) :
singlePromiseResolver(resolvedInput);
var promiseResolver = angular.isArray(resolvedInput)
? multiPromiseResolver(singlePromiseResolver, resolvedInput)
: singlePromiseResolver(resolvedInput);
promiseResolver.then(linkContent, removeContent);

6
horizon/static/framework/widgets/magic-search/hz-magic-search-bar.directive.js
View File

@ -108,9 +108,9 @@
cancel: gettext('Cancel'),
prompt: gettext('Click here for filters.'),
remove: gettext('Remove'),
text: (scope.clientFullTextSearch ?
gettext('Search in current results') :
gettext('Full Text Search'))
text: (scope.clientFullTextSearch
? gettext('Search in current results')
: gettext('Full Text Search'))
};
scope.filterStrings = scope.filterStrings || defaultFilterStrings;

4
horizon/static/horizon/js/horizon.quota.js
View File

@ -100,8 +100,8 @@ horizon.Quota = {
*/
noteDisabledFlavors: function(allDisabled) {
if ($('#some_flavors_disabled').length === 0) {
var message = allDisabled ? horizon.Quota.allFlavorsDisabledMessage :
horizon.Quota.disabledFlavorMessage;
var message = allDisabled ? horizon.Quota.allFlavorsDisabledMessage
: horizon.Quota.disabledFlavorMessage;
$('#id_flavor').parent().append("<span id='some_flavors_disabled'>" +
message + '</span>');
}

2
package.json
View File

@ -6,7 +6,7 @@
"repository": "none",
"license": "Apache 2.0",
"devDependencies": {
"eslint": "1.2.1",
"eslint": "1.10.3",
"eslint-config-openstack": "1.2.3",
"eslint-plugin-angular": "0.15.0",
"jasmine-core": "2.2.0",