openstack/horizon
Code Issues Proposed changes

Merge "Fix image description field"

Browse Source
This commit is contained in:
Zuul 2018-07-23 19:33:09 +00:00 committed by Gerrit Code Review
commit 995c1225b6
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstack_dashboard/static/app/core/images/actions/edit.action.service.js
View File

@ -103,7 +103,8 @@
.then(onMetadataGet);
function onMetadataGet(response) {
var updated = metadata;
var updated = metadata || Object();
updated.description = image.properties.description;
var removed = angular.copy(response.data);
angular.forEach(updated, function(value, key) {
delete removed[key];

2
openstack_dashboard/static/app/core/images/actions/edit.action.service.spec.js
View File

@ -19,7 +19,7 @@
describe('horizon.app.core.images.actions.edit.service', function() {
var service, $scope, $q, deferred, $timeout, updateImageDeferred;
var image = {id: 1, name: 'Original'};
var image = {id: 1, name: 'Original', properties: {description: 'bla-bla'}};
var existingMetadata = {p1: '1', p2: '2'};
var metadataService = {

5
releasenotes/notes/image-description-3fc00c02f46a80c7.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
Fix an error on image description field when it is changed
in the Angularized panel [:bug: `1779879`]