openstack
/
horizon
Code Issues Proposed changes

security_groups panel: Add neutron policy enforcement 

Bug: 1915308
Change-Id: Id6b802faba3f5260ce084b8f8bafedc6324d780d
This commit is contained in:
Andrew Bogott 2021-02-10 12:12:34 -06:00
parent a4cea370d4
commit 9ad5542486
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
openstack_dashboard/dashboards/project/security_groups/tables.py
View File

@ -28,10 +28,9 @@ from openstack_dashboard import policy
from openstack_dashboard.usage import quotas
from openstack_dashboard.utils import filters
# TODO(amotoki): [drop-nova-network] Add neutron policy support
class DeleteGroup(policy.PolicyTargetMixin, tables.DeleteAction):
policy_rules = (("network", "delete_security_group"),)
@staticmethod
def action_present(count):
@ -58,12 +57,13 @@ class DeleteGroup(policy.PolicyTargetMixin, tables.DeleteAction):
api.neutron.security_group_delete(request, obj_id)
class CreateGroup(tables.LinkAction):
class CreateGroup(policy.PolicyTargetMixin, tables.LinkAction):
name = "create"
verbose_name = _("Create Security Group")
url = "horizon:project:security_groups:create"
classes = ("ajax-modal",)
icon = "plus"
policy_rules = (("network", "create_security_group"),)
def allowed(self, request, security_group=None):
usages = quotas.tenant_quota_usages(request,
@ -85,6 +85,7 @@ class EditGroup(policy.PolicyTargetMixin, tables.LinkAction):
url = "horizon:project:security_groups:update"
classes = ("ajax-modal",)
icon = "pencil"
policy_rules = (("network", "update_security_group"),)
def allowed(self, request, security_group=None):
if not security_group:
@ -97,6 +98,7 @@ class ManageRules(policy.PolicyTargetMixin, tables.LinkAction):
verbose_name = _("Manage Rules")
url = "horizon:project:security_groups:detail"
icon = "pencil"
policy_rules = (("network", "get_security_group_rule"),)
class SecurityGroupsFilterAction(tables.FilterAction):
@ -124,12 +126,13 @@ class SecurityGroupsTable(tables.DataTable):
row_actions = (ManageRules, EditGroup, DeleteGroup)
class CreateRule(tables.LinkAction):
class CreateRule(policy.PolicyTargetMixin, tables.LinkAction):
name = "add_rule"
verbose_name = _("Add Rule")
url = "horizon:project:security_groups:add_rule"
classes = ("ajax-modal",)
icon = "plus"
policy_rules = (("network", "create_security_group_rule"),)
def get_link_url(self):
return reverse(self.url, args=[self.table.kwargs['security_group_id']])
@ -148,7 +151,9 @@ class CreateRule(tables.LinkAction):
return True
class DeleteRule(tables.DeleteAction):
class DeleteRule(policy.PolicyTargetMixin, tables.DeleteAction):
policy_rules = (("network", "delete_security_group_rule"),)
@staticmethod
def action_present(count):
return ungettext_lazy(

3
openstack_dashboard/dashboards/project/security_groups/tests.py
View File

@ -113,7 +113,8 @@ class SecurityGroupsViewTests(test.TestCase):
self.assertEqual('Create Security Group',
create_action.verbose_name)
self.assertIsNone(create_action.policy_rules)
self.assertEqual((('network', 'create_security_group'),),
create_action.policy_rules)
self.assertEqual(set(['ajax-modal']), set(create_action.classes))
url = 'horizon:project:security_groups:create'