Icon font carets should be used over caret class

Icon font carets should be used over the caret class because they
offer more flexibility while themeing. An Icon Font will grow with
the font size dynamically, whereas the caret class is hardcoded to
a specific set of sizes. Also, the fa-caret-down has the same feel
of the other icons --> showing a slight border radius.

Change-Id: I01c01df96d9d3d1bf07b009f94776d53389e0c32
Partially-Implements: blueprint horizon-theme-icons

horizon/static/framework/widgets/action-list/action-list.spec.js

@@ -114,7 +114,7 @@
 
       it('should have one caret button', function () {
         expect($element.find('.split-caret').length).toBe(1);
-        expect($element.find('.caret').length).toBe(1);
+        expect($element.find('.fa-caret-down').length).toBe(1);
       });
 
       it('should have 2 menu items', function () {

horizon/static/framework/widgets/action-list/single-button.html

@@ -4,5 +4,5 @@
   ng-class="actionClasses"
   ng-click="disabled || callback(item)">
   <ng-transclude></ng-transclude>
-  <span class="caret"></span>
+  <span class="fa fa-caret-down"></span>
 </button>

horizon/static/framework/widgets/action-list/split-button.html

@@ -10,6 +10,6 @@
   ng-class="actionClasses"
   ng-disabled="disabled"
   aria-expanded="false">
-  <span class="caret"></span>
+  <span class="fa fa-caret-down"></span>
   <span class="sr-only">Toggle Dropdown</span>
 </button>

horizon/templates/horizon/common/_data_table_row_actions_dropdown.html

@@ -7,7 +7,7 @@
         {% if forloop.first %}
           {% include "horizon/common/_data_table_row_action_dropdown.html" %}
           <a class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown" href="#">
-            <span class="caret"></span>
+            <span class="fa fa-caret-down"></span>
           </a>
           <ul class="dropdown-menu row_actions dropdown-menu-right clearfix">
         {% else %}

horizon/templates/horizon/common/_data_table_table_actions.html

@@ -46,7 +46,7 @@
         {% else %}
           {% trans "Actions" %}
         {% endif %}
-        <span class="caret"></span>
+        <span class="fa fa-caret-down"></span>
       </a>
       <ul class="dropdown-menu clearfix">
       {% for action in table_actions_menu %}

horizon/templates/horizon/common/_region_selector.html

@@ -3,7 +3,7 @@
   <div id="region_switcher" class="dropdown switcher_bar" tabindex='1'>
     <button class="btn btn-default btn-topnav dropdown-toggle" data-toggle="dropdown">
       {{ regions.current.name }}
-      <span class="caret"></span>
+      <span class="fa fa-caret-down"></span>
     </button>
     <ul id="region_list" class="dropdown-menu topbar-dropdown-menu">
       {% for region in regions.available %}

openstack_dashboard/templates/_header.html

@@ -24,7 +24,7 @@
     <button class="btn btn-default btn-topnav dropdown-toggle">
       <span class="fa fa-user"></span>
       {{ request.user.username }}
-      <span class="caret"></span>
+      <span class="fa fa-caret-down"></span>
     </button>
     <ul id="editor_list" class="dropdown-menu topbar-dropdown-menu pull-right">
       <li>

openstack_dashboard/templates/context_selection/_overview.html

@@ -10,4 +10,4 @@
     <span>{{ region_name }}</span>
     {% endif %}
   </span>
-<span class="caret"></span>
+<span class="fa fa-caret-down"></span>