openstack/horizon
Code Issues Proposed changes

Icon font carets should be used over caret class

Browse Source 
Icon font carets should be used over the caret class because they
offer more flexibility while themeing. An Icon Font will grow with
the font size dynamically, whereas the caret class is hardcoded to
a specific set of sizes. Also, the fa-caret-down has the same feel
of the other icons --> showing a slight border radius.

Change-Id: I01c01df96d9d3d1bf07b009f94776d53389e0c32
Partially-Implements: blueprint horizon-theme-icons
This commit is contained in:
Diana Whitten 2015-06-25 11:05:40 -07:00
parent 3917d8e196
commit 9ae749512d
8 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
horizon/static/framework/widgets/action-list/action-list.spec.js
View File

@ -114,7 +114,7 @@
it('should have one caret button', function () { it('should have one caret button', function () {
expect($element.find('.split-caret').length).toBe(1); expect($element.find('.split-caret').length).toBe(1);
expect($element.find('.caret').length).toBe(1); expect($element.find('.fa-caret-down').length).toBe(1);
}); });
it('should have 2 menu items', function () { it('should have 2 menu items', function () {

2
horizon/static/framework/widgets/action-list/single-button.html
View File

@ -4,5 +4,5 @@
ng-class="actionClasses" ng-class="actionClasses"
ng-click="disabled || callback(item)"> ng-click="disabled || callback(item)">
<ng-transclude></ng-transclude> <ng-transclude></ng-transclude>
<span class="caret"></span> <span class="fa fa-caret-down"></span>
</button> </button>

2
horizon/static/framework/widgets/action-list/split-button.html
View File

@ -10,6 +10,6 @@
ng-class="actionClasses" ng-class="actionClasses"
ng-disabled="disabled" ng-disabled="disabled"
aria-expanded="false"> aria-expanded="false">
<span class="caret"></span> <span class="fa fa-caret-down"></span>
<span class="sr-only">Toggle Dropdown</span> <span class="sr-only">Toggle Dropdown</span>
</button> </button>

2
horizon/templates/horizon/common/_data_table_row_actions_dropdown.html
View File

@ -7,7 +7,7 @@
{% if forloop.first %} {% if forloop.first %}
{% include "horizon/common/_data_table_row_action_dropdown.html" %} {% include "horizon/common/_data_table_row_action_dropdown.html" %}
<a class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown" href="#"> <a class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown" href="#">
<span class="caret"></span> <span class="fa fa-caret-down"></span>
</a> </a>
<ul class="dropdown-menu row_actions dropdown-menu-right clearfix"> <ul class="dropdown-menu row_actions dropdown-menu-right clearfix">
{% else %} {% else %}

2
horizon/templates/horizon/common/_data_table_table_actions.html
View File

@ -46,7 +46,7 @@
{% else %} {% else %}
{% trans "Actions" %} {% trans "Actions" %}
{% endif %} {% endif %}
<span class="caret"></span> <span class="fa fa-caret-down"></span>
</a> </a>
<ul class="dropdown-menu clearfix"> <ul class="dropdown-menu clearfix">
{% for action in table_actions_menu %} {% for action in table_actions_menu %}

2
horizon/templates/horizon/common/_region_selector.html
View File

@ -3,7 +3,7 @@
<div id="region_switcher" class="dropdown switcher_bar" tabindex='1'> <div id="region_switcher" class="dropdown switcher_bar" tabindex='1'>
<button class="btn btn-default btn-topnav dropdown-toggle" data-toggle="dropdown"> <button class="btn btn-default btn-topnav dropdown-toggle" data-toggle="dropdown">
{{ regions.current.name }} {{ regions.current.name }}
<span class="caret"></span> <span class="fa fa-caret-down"></span>
</button> </button>
<ul id="region_list" class="dropdown-menu topbar-dropdown-menu"> <ul id="region_list" class="dropdown-menu topbar-dropdown-menu">
{% for region in regions.available %} {% for region in regions.available %}

2
openstack_dashboard/templates/_header.html
View File

@ -24,7 +24,7 @@
<button class="btn btn-default btn-topnav dropdown-toggle"> <button class="btn btn-default btn-topnav dropdown-toggle">
<span class="fa fa-user"></span> <span class="fa fa-user"></span>
{{ request.user.username }} {{ request.user.username }}
<span class="caret"></span> <span class="fa fa-caret-down"></span>
</button> </button>
<ul id="editor_list" class="dropdown-menu topbar-dropdown-menu pull-right"> <ul id="editor_list" class="dropdown-menu topbar-dropdown-menu pull-right">
<li> <li>

2
openstack_dashboard/templates/context_selection/_overview.html
View File

@ -10,4 +10,4 @@
<span>{{ region_name }}</span> <span>{{ region_name }}</span>
{% endif %} {% endif %}
</span> </span>
<span class="caret"></span> <span class="fa fa-caret-down"></span>