openstack
/
horizon
Code Issues Proposed changes

Use raw data for inline edits of boolean fields 

Boolean fields use filters to turn the True/False values into Yes/No
but this makes the inline edit checkbox always checked. This patch
will use the raw data for the cell when setting the value for the
inline edit checkbox so that it is correctly checked or not checked.

Closes-Bug: #1496417
Change-Id: I9edb0a1d1b88b918ba334393c44e8389f6c785a4
This commit is contained in:
Justin Pomeroy 2015-09-16 09:25:56 -05:00
parent 0aa2a8b479
commit 9d54f16b07
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
horizon/tables/base.py
View File

@ -688,7 +688,8 @@ class Cell(html.HTMLElement):
# Adding id of the input so it pairs with label correctly
form_field_attributes['id'] = widget_name
if template.defaultfilters.urlize in column.filters:
if (template.defaultfilters.urlize in column.filters or
template.defaultfilters.yesno in column.filters):
data = widget.render(widget_name,
column.get_raw_data(datum),
form_field_attributes)