openstack
/
horizon
Code Issues Proposed changes

Jshint unused and undef cleanup for accordion_nav, tabs JS 

Removing unused and undefined variables in accordion_nav, tabs
javascript. This ensures that once we enable it globally, the
gate will not barf.

Change-Id: I9a8f6c6b71ebc770b4f060ccf4b0b3a1cce8f7d9
Partial-bug: #1438620
This commit is contained in:
Cindy Lu 2015-04-23 11:23:14 -07:00
parent bafcfb02de
commit a3859392c6
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
horizon/static/horizon/js/horizon.accordion_nav.js
View File

@ -58,7 +58,7 @@ horizon.addInitFunction(function() {
// panel group click
$('.nav_accordion > dd > div > h4').click(function() {
var myPanelGroupHeader = $(this);
myPanelGroupWasActive = myPanelGroupHeader.hasClass("active");
var myPanelGroupWasActive = myPanelGroupHeader.hasClass("active");
// collapse all panel groups
var allPanelGroupHeaders = $('.nav_accordion > dd > div > h4');

4
horizon/static/horizon/js/horizon.tabs.js
View File

@ -12,7 +12,7 @@ horizon.tabs.initTabLoad = function (tab) {
});
};
horizon.tabs.load_tab = function (evt) {
horizon.tabs.load_tab = function () {
var $this = $(this),
tab_id = $this.attr('data-target'),
tab_pane = $(tab_id);
@ -60,7 +60,7 @@ horizon.addInitFunction(horizon.tabs.init = function () {
});
// Initialize stored tab state for tab groups on this page.
$(".nav-tabs[data-sticky-tabs='sticky']").each(function (index, item) {
$(".nav-tabs[data-sticky-tabs='sticky']").each(function () {
var $this = $(this),
id = $this.attr("id"),
active_tab = data[id];