openstack/horizon
Code Issues Proposed changes

Revert "Ignore the ng_on_watch error from eslint"

Browse Source 
This reverts commit 9b210766508bfeab6cb7f1c4d0c1524a51209613.

The original commit was merged with a -1. The concern raised was
that it does not force engineers to clean up after themselves, which
is a best practice explicitly mentioned in the John Papa style guides
under Y070. While this rule is only specific to directives, it's
common sense, and the directive to "clean up your pointers" goes
back as far as C.

https://github.com/johnpapa/angular-styleguide#style-y070

Change-Id: Iea243c2b0b3c6154c5b02fd9e29172e1d5e3b434
This commit is contained in:
Michael Krotscheck 2015-07-13 08:54:06 -07:00
parent a336dbd707
commit acf0511944
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.eslintrc
View File

@ -809,10 +809,6 @@ rules:
# http://eslint.org/docs/rules/no-plusplus
no-plusplus: 0
# Disable check for the watch on scope
# This rule is not part of John Papa's ruleset
# https://github.com/Gillespie59/eslint-plugin-angular/issues/114
angular/ng_on_watch: 0
# We only support ECMA5, disable everything else.
ecmaFeatures: