openstack/horizon
Code Issues Proposed changes

Add expect clause when the test passes

Browse Source 
tests in q.extensions.spec.js are not asserting anything
when the tests pass. This causes an error when running
jasmine.

Change-Id: I0589622944bdeaa69814181a431358b7c307219f
Partial-Bug: #1532170
This commit is contained in:
Rajat Vig 2016-01-08 10:30:38 -08:00
parent 2b6f9525a8
commit b029b70937
1 changed files with 15 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
horizon/static/framework/util/q/q.extensions.spec.js
View File

@ -49,7 +49,7 @@
}, { }, {
promise: passedPromise(), promise: passedPromise(),
context: '2' context: '2'
}]).then(onAllSettled, failTest); }]).then(onAllSettled);
$scope.$apply(); $scope.$apply();
@ -76,28 +76,26 @@
}); });
it('should reject the promise if condition does not evaluates to true', function() { it('should reject the promise if condition does not evaluates to true', function() {
service.booleanAsPromise(false).then(failTest, angular.noop); var testValues = [ false, null, {}, 'A', 7 ];
$scope.$apply(); var rejectCount = 0;
service.booleanAsPromise(null).then(failTest, angular.noop); testValues.map(function doTest(testValue) {
$scope.$apply(); service.booleanAsPromise(testValue).then(angular.noop, function failTest() {
service.booleanAsPromise({}).then(failTest, angular.noop); rejectCount++;
$scope.$apply(); });
service.booleanAsPromise('A').then(failTest, angular.noop);
$scope.$apply();
service.booleanAsPromise(7).then(failTest, angular.noop);
$scope.$apply(); $scope.$apply();
}); });
expect(rejectCount).toEqual(testValues.length);
});
it('should resolve the promise only if condition to true', function() { it('should resolve the promise only if condition to true', function() {
service.booleanAsPromise(true).then(angular.noop, failTest); var passCount = 0;
service.booleanAsPromise(true).then(function passTest() {
passCount++;
});
$scope.$apply(); $scope.$apply();
expect(passCount).toEqual(1);
}); });
}); });
function failTest() {
expect(false).toBeTruthy();
}
}); });
})(); })();