openstack/horizon
Code Issues Proposed changes

Jshint removing Hogan and static_url

Browse Source 
Hogan and STATIC_URL are only use in a few files. Hence, we do not really
need them enabled globally. Removing them from jshint global config.

Change-Id: I0881ab0e6668a47bf795e422e17f9f025a010d31
Closes-bug: #1452464
This commit is contained in:
Thai Tran
2015-05-06 14:33:53 -07:00
parent ef11284817
commit b4e92f7273
4 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.jshintrc
View File

@@ -7,7 +7,6 @@
"globals": { "globals": {
"horizon": false, "horizon": false,
"STATIC_URL": false,
"jQuery": false, "jQuery": false,
"$": false, "$": false,
@@ -27,7 +26,6 @@
"jasmine": false, "jasmine": false,
"d3": false, "d3": false,
"Hogan": false,
"test": false, "test": false,
"equal": false, "equal": false,
"ok": false, "ok": false,

1
horizon/static/horizon/js/horizon.networktopology.js
View File

@@ -1,3 +1,4 @@
/* global Hogan */
/* Namespace for core functionality related to Network Topology. */ /* Namespace for core functionality related to Network Topology. */
horizon.network_topology = { horizon.network_topology = {

1
horizon/static/horizon/js/horizon.tables.js
View File

@@ -1,3 +1,4 @@
/* global STATIC_URL */
/* Namespace for core functionality related to DataTables. */ /* Namespace for core functionality related to DataTables. */
horizon.datatables = { horizon.datatables = {
update: function () { update: function () {

1
horizon/static/horizon/js/horizon.templates.js
View File

@@ -1,3 +1,4 @@
/* global Hogan */
/* Namespace for core functionality related to client-side templating. */ /* Namespace for core functionality related to client-side templating. */
horizon.templates = { horizon.templates = {
template_ids: ["#modal_template", "#empty_row_template", "#alert_message_template", "#spinner-modal", "#membership_template"], template_ids: ["#modal_template", "#empty_row_template", "#alert_message_template", "#spinner-modal", "#membership_template"],