From b5f4d63c7ca3f1dec87aa7fec1110e0bdc579e2b Mon Sep 17 00:00:00 2001 From: David Lyle Date: Wed, 27 Feb 2013 11:27:33 -0700 Subject: [PATCH] Fix errant XHR request happening on every page The check of the jquery selector by name will always return a non-null object even if the object does not exist on the page, the check needs to make sure the object returned doesn't contain any items. Change-Id: I51367547a37a2ee72ed300853d35d3cc6d89df7d Fixes: bug #1132588 --- horizon/static/horizon/js/horizon.networktopology.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/horizon/static/horizon/js/horizon.networktopology.js b/horizon/static/horizon/js/horizon.networktopology.js index 9007ddb845..3247b5cde5 100644 --- a/horizon/static/horizon/js/horizon.networktopology.js +++ b/horizon/static/horizon/js/horizon.networktopology.js @@ -21,11 +21,11 @@ horizon.network_topology = { $("#topologyCanvas").spin(horizon.conf.spinner_options.modal); self.retrieve_network_info(); setInterval(horizon.network_topology.retrieve_network_info, - horizon.network_topology.reload_duration); + horizon.network_topology.reload_duration); }, retrieve_network_info: function(){ var self = this; - if(!$("#networktopology")) { + if($("#networktopology").length === 0) { return; } $.getJSON($("#networktopology").data('networktopology'),