openstack
/
horizon
Code Issues Proposed changes

Make extract_messages quiet in pep8 test 

The additional extract_messages call in the pep8 tox environment
generates a lot of meaningless output, that then makes it difficult
to spot actual failures and warnings. This patch makes the Django
command respect the verbosity setting and call the setup.py command
with a quiet flag if low verbosity is requested, considerably decreasing
the amount of useless output. It then sets that verbosity to low in the
corresponding tox environment.

Change-Id: I2976250a23e800fbb582726299670b57199b58a7
This commit is contained in:
Radomir Dopieralski 2017-03-15 18:41:19 +01:00
parent 4187837434
commit c3b6fc761e
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openstack_dashboard/management/commands/extract_messages.py
View File

@ -37,11 +37,13 @@ class Command(BaseCommand):
"polluting the source code"))
def handle(self, *args, **options):
cmd = ('python setup.py extract_messages -F babel-{domain}.cfg '
cmd = ('python setup.py {quiet} extract_messages '
'-F babel-{domain}.cfg '
'-o {module}/locale/{domain}.pot')
distribution = Distribution()
distribution.parse_config_files(distribution.find_config_files())
quiet = '-q' if int(options['verbosity']) == 0 else ''
if options['check_only']:
cmd += " ; rm {module}/locale/{domain}.pot"
@ -53,5 +55,5 @@ class Command(BaseCommand):
with open(potfile, 'wb') as f:
f.write(b'')
call(cmd.format(module=module, domain=domain, potfile=potfile),
shell=True)
call(cmd.format(module=module, domain=domain, potfile=potfile,
quiet=quiet), shell=True)

2
tox.ini
View File

@ -56,7 +56,7 @@ commands = bash {toxinidir}/tools/unit_tests.sh {envpython} {toxinidir} {posargs
[testenv:pep8]
usedevelop = True
commands =
{envpython} {toxinidir}/manage.py extract_messages --check-only
{envpython} {toxinidir}/manage.py extract_messages --verbosity 0 --check-only
flake8
[testenv:cover]