openstack/horizon
Code Issues Proposed changes

Fix show/hide password when clicking password icon

Browse Source 
This patch overrides a Bootstrap's default property that disables
mouse events on elements with .form-control-feedback class. The password
icon had pointer-events: none; affecting password reveal functionality
in login form and Identity->Users->Create User. It also modifies the default
cursor for the password icon with pointer.

This patch also fixes a bug where the Eye Icon is misaligned when passwords
don't match (See #1604196)

Change-Id: I052321a5cc9adc1a7ffdfce4da0b55c245481a2d
Closes-bug: #1593430
Closes-bug: #1604196
This commit is contained in:
Eddie Ramirez 2016-07-18 17:46:54 +00:00
parent 8f35c43bc5
commit ccdb7b4ffd
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
horizon/static/horizon/js/horizon.users.js
View File

@ -21,8 +21,7 @@ horizon.user = {
var confirm_password = $("#id_confirm_password").val();
if (password !== confirm_password && $("#" + error_id).length === 0) {
$(row).parent().addClass("has-error");
$(row).after(msg);
$(row).parent().addClass("has-error").append(msg);
} else if (password === confirm_password) {
$(row).parent().removeClass("has-error");
$("#" + error_id).remove();

5
openstack_dashboard/static/dashboard/scss/components/_forms.scss
View File

@ -10,4 +10,9 @@
line-height: $input-height-base;
top: 0;
}
.password-icon {
cursor: pointer;
pointer-events: auto;
}
}