From cd64730ee4f560016363f4e05b176dac4e678757 Mon Sep 17 00:00:00 2001
From: Michel Nederlof <mnederlof@cloudvps.com>
Date: Tue, 30 May 2023 16:17:01 +0200
Subject: [PATCH] Fix object-store container toggle for turning public access
 on/off

After updating to angular 1.8, changes to a object (in this case the
container object) has changed from the click event to the onchange event
for input radio's and checkboxes as described on
https://docs.angularjs.org/guide/migration#-input-radio-and-input-checkbox-

In our scenario this means the container.is_public value is changed
_after_ the ajax call went to the horizon API, effectively not changing it.

This change fixes this, by migrating to the ng-change event for this toggle

Closes-Bug: #2020879
Change-Id: If3b87da6d747bb7e738b64f4c2f3472a7556c652
---
 .../project/static/dashboard/project/containers/containers.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openstack_dashboard/dashboards/project/static/dashboard/project/containers/containers.html b/openstack_dashboard/dashboards/project/static/dashboard/project/containers/containers.html
index 34194763a7..e122978da2 100644
--- a/openstack_dashboard/dashboards/project/static/dashboard/project/containers/containers.html
+++ b/openstack_dashboard/dashboards/project/static/dashboard/project/containers/containers.html
@@ -73,7 +73,7 @@
                   <div class="themable-checkbox col-lg-7 col-md-12">
                     <input type="checkbox" id="id_access" ng-model="container.is_public"
                            ng-if="container.name === cc.model.container.name"
-                           ng-click="cc.toggleAccess(container)">
+                           ng-change="cc.toggleAccess(container)">
                     <label class="hz-object-label" for="id_access" translate>Public Access</label>
                   </div>
                   <span class="hz-object-val col-lg-5 col-md-12">