openstack/horizon
Code Issues Proposed changes

pytest-based tests move help_url test

Browse Source 
Move help_url test from UI tests to integration tests
as the help_url is a setting and integration tests
check for correct settings and UI tests check if
the mechanism for those settings works.

Change-Id: I41d38e1d51151f1e7b78c6591801552b9bf86f8e
This commit is contained in:
Jan Jasek 2024-11-18 10:14:09 +01:00
parent 0763ff9f5b
commit db0d6a04ee
2 changed files with 37 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
openstack_dashboard/test/selenium/integration/test_settings.py Normal file
View File

@ -0,0 +1,37 @@
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.support.wait import WebDriverWait
from openstack_dashboard.test.selenium import widgets
def test_dashboard_help_redirection(login, driver, config):
login('user')
url = '/'.join((
config.dashboard.dashboard_url,
'settings',
))
driver.get(url)
user_dropdown_menu = driver.find_element_by_css_selector(
'.nav.navbar-nav.navbar-right')
widgets.select_from_dropdown(user_dropdown_menu, "Help")
available_windows = driver.window_handles
assert len(available_windows) == 2
driver.switch_to.window(available_windows[-1])
WebDriverWait(driver, config.selenium.page_timeout).until(
EC.visibility_of_element_located((By.CSS_SELECTOR, 'h1')))
assert config.dashboard.help_url in driver.current_url
driver.close()
driver.switch_to.window(available_windows[0])

15
openstack_dashboard/test/selenium/ui/test_settings.py
View File

@ -52,21 +52,6 @@ def test_languages(live_server, driver, user):
assert "Error" not in messages assert "Error" not in messages
def test_dashboard_help_redirection(live_server, driver, user, config):
driver.get(live_server.url + '/settings')
user_dropdown_menu = driver.find_element_by_css_selector(
'.nav.navbar-nav.navbar-right')
widgets.select_from_dropdown(user_dropdown_menu, "Help")
available_windows = driver.window_handles
assert len(available_windows) == 2
driver.switch_to.window(available_windows[-1])
WebDriverWait(driver, config.selenium.page_timeout).until(
EC.visibility_of_element_located((By.CSS_SELECTOR, '.navbar-brand')))
assert config.dashboard.help_url in driver.current_url
driver.close()
driver.switch_to.window(available_windows[0])
def test_switch_to_material_theme(live_server, driver, user, config): def test_switch_to_material_theme(live_server, driver, user, config):
driver.get(live_server.url + '/settings') driver.get(live_server.url + '/settings')
user_dropdown_menu = driver.find_element_by_css_selector( user_dropdown_menu = driver.find_element_by_css_selector(