openstack/horizon
Code Issues Proposed changes

Fix Http302 error message in UT

Browse Source 
When running openstack_dashboard unit tests,
we see an error message:

    Error while checking action permissions.
    ...
    Http302

This is caused by unsufficient mocking.

Change-Id: I0edb89a0e804f38be891c9397438fce0ddd469ff
This commit is contained in:
Akihiro Motoki 2017-09-20 08:00:55 +00:00
parent 40b76ff9fc
commit ee989fc925
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
openstack_dashboard/dashboards/admin/networks/tests.py
View File

@ -24,6 +24,7 @@ from horizon import forms
from openstack_dashboard import api
from openstack_dashboard.dashboards.project.networks import tests
from openstack_dashboard.test import helpers as test
from openstack_dashboard import usage
INDEX_TEMPLATE = 'horizon/common/_data_table_view.html'
INDEX_URL = reverse('horizon:admin:networks:index')
@ -157,13 +158,18 @@ class NetworkTests(test.BaseAdminViewTests):
'subnet_list',
'port_list',
'is_extension_supported',
'list_dhcp_agent_hosting_networks',)})
'list_dhcp_agent_hosting_networks',),
usage.quotas: ('tenant_quota_usages',)})
def test_network_detail_ports_tab(self, mac_learning=False):
network_id = self.networks.first().id
api.neutron.network_get(IsA(http.HttpRequest), network_id)\
.AndReturn(self.networks.first())
api.neutron.port_list(IsA(http.HttpRequest), network_id=network_id)\
network = self.networks.first()
api.neutron.network_get(IsA(http.HttpRequest), network.id)\
.MultipleTimes().AndReturn(self.networks.first())
api.neutron.port_list(IsA(http.HttpRequest), network_id=network.id)\
.AndReturn([self.ports.first()])
quota_data = self.neutron_quota_usages.first()
usage.quotas.tenant_quota_usages(
IsA(http.HttpRequest), tenant_id=network.tenant_id,
targets=('ports',)).MultipleTimes().AndReturn(quota_data)
api.neutron.is_extension_supported(
IsA(http.HttpRequest),
'network-ip-availability').AndReturn(True)
@ -176,7 +182,7 @@ class NetworkTests(test.BaseAdminViewTests):
self.mox.ReplayAll()
url = reverse('horizon:admin:networks:ports_tab',
args=[network_id])
args=[network.id])
res = self.client.get(urlunquote(url))
self.assertTemplateUsed(res, 'horizon/common/_detail.html')