Removed JSHint

JSHint is being deprecated by the Horizon project. This removes all
references, commands, and documentation related to this tool. The
patch depends on the deactivation patch for jshint in infra.

Change-Id: I1a799f39023e0598a58d912a4288300ec8340dd9
Depends-on: Ifb59af36ae37926133769c655e54f4c2e1edf095
Partially-Implements: blueprint jscs-cleanup
This commit is contained in:
Michael Krotscheck 2015-06-26 14:30:00 -07:00
parent 849c3cc5d7
commit eff59ac2dd
7 changed files with 1 additions and 69 deletions

View File

@ -1 +0,0 @@
horizon/static/horizon/lib/

View File

@ -1,42 +0,0 @@
{
"browser": true,
"trailing": true,
"evil": true,
"unused": true,
"undef": true,
"globals": {
"horizon": false,
"jQuery": false,
"$": false,
"angular": false,
"module": false,
"inject": false,
"describe": false,
"beforeEach": false,
"afterEach": false,
"beforeAll": false,
"afterAll": false,
"it": false,
"expect": false,
"fail": false,
"spyOn": false,
"jasmine": false,
"d3": false,
"test": false,
"equal": false,
"ok": false,
"pluralidx": false,
"gettext": false,
"ngettext": false,
"gettext_noop": false,
"pgettext": false,
"npgettext": false,
"interpolate": false,
"get_format": false
}
}

View File

@ -1,4 +1,3 @@
/* jshint browser: true */
(function() { (function() {
'use strict'; 'use strict';

View File

@ -88,7 +88,6 @@
function add(type, msg) { function add(type, msg) {
var toast = { var toast = {
type: type === 'error' ? 'danger' : type, type: type === 'error' ? 'danger' : type,
/* jshint validthis:true */
typeMsg: this.types[type], typeMsg: this.types[type],
msg: msg, msg: msg,
cancel: cancel cancel: cancel

View File

@ -42,4 +42,4 @@ var Horizon = function () {
}; };
// Create the one and only horizon object. // Create the one and only horizon object.
var horizon = new Horizon(); // jshint ignore:line var horizon = new Horizon();

View File

@ -26,7 +26,6 @@ function usage {
echo " -P, --no-pep8 Don't run pep8 by default" echo " -P, --no-pep8 Don't run pep8 by default"
echo " -t, --tabs Check for tab characters in files." echo " -t, --tabs Check for tab characters in files."
echo " -y, --pylint Just run pylint" echo " -y, --pylint Just run pylint"
echo " -j, --jshint Just run jshint"
echo " -e, --eslint Just run eslint" echo " -e, --eslint Just run eslint"
echo " -k, --karma Just run karma" echo " -k, --karma Just run karma"
echo " -q, --quiet Run non-interactively. (Relatively) quiet." echo " -q, --quiet Run non-interactively. (Relatively) quiet."
@ -72,7 +71,6 @@ just_pylint=0
just_docs=0 just_docs=0
just_tabs=0 just_tabs=0
just_eslint=0 just_eslint=0
just_jshint=0
just_karma=0 just_karma=0
never_venv=0 never_venv=0
quiet=0 quiet=0
@ -109,7 +107,6 @@ function process_option {
-8|--pep8-changed) just_pep8_changed=1;; -8|--pep8-changed) just_pep8_changed=1;;
-P|--no-pep8) no_pep8=1;; -P|--no-pep8) no_pep8=1;;
-y|--pylint) just_pylint=1;; -y|--pylint) just_pylint=1;;
-j|--jshint) just_jshint=1;;
-e|--eslint) just_eslint=1;; -e|--eslint) just_eslint=1;;
-k|--karma) just_karma=1;; -k|--karma) just_karma=1;;
-f|--force) force=1;; -f|--force) force=1;;
@ -159,14 +156,6 @@ function run_pylint {
fi fi
} }
function run_jshint {
echo "Running jshint ..."
jshint horizon/static/horizon/js
jshint horizon/static/horizon/tests
jshint horizon/static/framework/
jshint openstack_dashboard/static/dashboard/
}
function run_eslint { function run_eslint {
echo "Running eslint ..." echo "Running eslint ..."
if [ "`which npm`" == '' ] ; then if [ "`which npm`" == '' ] ; then
@ -583,12 +572,6 @@ if [ $just_pylint -eq 1 ]; then
exit $? exit $?
fi fi
# Jshint
if [ $just_jshint -eq 1 ]; then
run_jshint
exit $?
fi
# ESLint # ESLint
if [ $just_eslint -eq 1 ]; then if [ $just_eslint -eq 1 ]; then
run_eslint run_eslint

View File

@ -44,12 +44,6 @@ commands = pip install django>=1.5,<1.6
basepython = python2.7 basepython = python2.7
commands = /bin/bash run_tests.sh -N --integration --selenium-headless {posargs} commands = /bin/bash run_tests.sh -N --integration --selenium-headless {posargs}
[testenv:jshint]
passenv = *
commands = nodeenv -p
npm install jshint -g
/bin/bash run_tests.sh -N --jshint
[testenv:eslint] [testenv:eslint]
passenv = * passenv = *
commands = nodeenv -p commands = nodeenv -p