From fdb21222b6061c1b42298a9c7d3380a8df6e837a Mon Sep 17 00:00:00 2001 From: Akihiro Motoki Date: Wed, 22 Mar 2017 21:44:27 +0000 Subject: [PATCH] operation_log: Honor settings parameters Previously 'format' and 'mask_fields' in OPERATION_LOG_OPTIONS were completely ignored. OPERATION_LOG_OPTIONS is a dict, but the logic tried to get attributes, so these options were ignored. Change-Id: Ide4826ebf74218873a81b67aaa0dd817c4798702 Closes-Bug: #1675176 --- horizon/middleware/operation_log.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/horizon/middleware/operation_log.py b/horizon/middleware/operation_log.py index 225c864831..7c13a098ea 100644 --- a/horizon/middleware/operation_log.py +++ b/horizon/middleware/operation_log.py @@ -65,8 +65,8 @@ class OperationLogMiddleware(object): " [%(request_scheme)s] [%(referer_url)s] [%(request_url)s]" " [%(message)s] [%(method)s] [%(http_status)s] [%(param)s]") self.target_methods = [x for x in _methods if x in _available_methods] - self.mask_fields = getattr(_log_option, "mask_fields", ['password']) - self.format = getattr(_log_option, "format", _default_format) + self.mask_fields = _log_option.get("mask_fields", ['password']) + self.format = _log_option.get("format", _default_format) self.static_rule = ['/js/', '/static/'] self._logger = logging.getLogger('horizon.operation_log')