openstack/horizon
Code Issues Proposed changes

Trivial: Remove unused 'horizon.app.core.images.events'

Browse Source 
Some javascript files are not using 'horizon.app.core.images.events'
after patch[1]. Remove the unused codes.

[1]https://review.openstack.org/#/c/291846/

Change-Id: I23b5ad60e03007096c0e250ee35c6cc0dd4d8f94
This commit is contained in:
wangbo 2016-05-20 19:55:38 +08:00
parent b50d0fc813
commit fffb26991c
6 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack_dashboard/static/app/core/images/actions/edit.action.service.js
View File

@ -24,7 +24,6 @@
editService.$inject = [
'$q',
'horizon.app.core.images.resourceType',
'horizon.app.core.images.events',
'horizon.app.core.images.actions.editWorkflow',
'horizon.app.core.metadata.service',
'horizon.app.core.openstack-service-api.glance',
@ -44,7 +43,6 @@
function editService(
$q,
imageResourceType,
events,
editWorkflow,
metadataService,
glance,

3
openstack_dashboard/static/app/core/images/actions/update-metadata.action.service.js
View File

@ -22,7 +22,6 @@
updateMetadataService.$inject = [
'$q',
'horizon.app.core.images.events',
'horizon.app.core.metadata.modal.service',
'horizon.app.core.openstack-service-api.userSession',
'horizon.framework.util.actions.action-result.service',
@ -35,7 +34,6 @@
* @name horizon.app.core.images.actions.updateMetadataService
*
* @param {Object} $q
* @param {Object} events
* @param {Object} metadataModalService
* @param {Object} userSessionService
* @param {Object} $qExtensions
@ -48,7 +46,6 @@
*/
function updateMetadataService(
$q,
events,
metadataModalService,
userSessionService,
actionResultService,

3
openstack_dashboard/static/app/core/images/images.module.js
View File

@ -154,10 +154,7 @@
*/
function events() {
return {
DELETE_SUCCESS: 'horizon.app.core.images.DELETE_SUCCESS',
VOLUME_CHANGED: 'horizon.app.core.images.VOLUME_CHANGED',
UPDATE_METADATA_SUCCESS: 'horizon.app.core.images.UPDATE_METADATA_SUCCESS',
UPDATE_SUCCESS: 'horizon.app.core.images.UPDATE_SUCCESS',
IMAGE_CHANGED: 'horizon.app.core.images.IMAGE_CHANGED',
IMAGE_METADATA_CHANGED: 'horizon.app.core.images.IMAGE_METADATA_CHANGED'
};

2
openstack_dashboard/static/app/core/images/steps/edit-image/edit-image.controller.js
View File

@ -23,7 +23,6 @@
EditImageController.$inject = [
'$scope',
'horizon.app.core.images.events',
'horizon.app.core.images.imageFormats',
'horizon.app.core.images.validationRules',
'horizon.app.core.openstack-service-api.settings'
@ -37,7 +36,6 @@
*/
function EditImageController(
$scope,
events,
imageFormats,
validationRules,
settings

4
openstack_dashboard/static/app/core/images/steps/edit-image/edit-image.controller.spec.js
View File

@ -19,7 +19,7 @@
describe('horizon.app.core.images edit image controller', function() {
var controller, $scope, events, $q, settingsCall, $timeout;
var controller, $scope, $q, settingsCall, $timeout;
///////////////////////
@ -33,7 +33,6 @@
$q = _$q_;
$timeout = _$timeout_;
events = $injector.get('horizon.app.core.images.events');
controller = $injector.get('$controller');
}));
@ -46,7 +45,6 @@
};
return controller('horizon.app.core.images.steps.EditImageController as ctrl', {
$scope: $scope,
events: events,
'horizon.app.core.openstack-service-api.settings': settings
});
}

3
openstack_dashboard/static/app/core/images/table/images.controller.js
View File

@ -26,7 +26,6 @@
'$scope',
'horizon.framework.widgets.toast.service',
'horizon.app.core.images.detailsRoute',
'horizon.app.core.images.events',
'horizon.app.core.images.resourceType',
'horizon.app.core.openstack-service-api.glance',
'horizon.app.core.openstack-service-api.policy',
@ -43,7 +42,6 @@
* @param {Object} $q
* @param {Object} $scope
* @param {String} detailsRoute
* @param {Object} events
* @param {Object} imageResourceType
* @param {Object} glance
* @param {Object} userSession
@ -60,7 +58,6 @@
$scope,
toast,
detailsRoute,
events,
imageResourceType,
glance,
policy,