This commit is as follow-up work of:https://review.openstack.org/#/c/261695/.
Mention how to use policy directive to complete policy.rst.
Change-Id: I64e64ba8d7fd0c2e15ffd0f460b9bb981742b4b9
Partial-Bug: #1529007
Added tutorial folder for future tutorials.
Added tutorial for creating and installing plugins.
Moved dashboard tutorial into tutorial folder.
Change-Id: I17c1ff279b47292d723c100b580667418aa05636
Closes-Bug: #1511593
Allow user to configure messages to display to the user
after they login.
Change-Id: I6dc0318708d0f964e52c8b127718297fc723651c
Implements: blueprint message-of-the-day
horizon/doc/source/topics/policy.rst has been out of date:
1."oslo-incubator" is not in using now.
2."openstack_dashboard/openstack/common/" has been removed
3.add how to use RBAC in javascript files for ng-panels
Change-Id: Ia10cf90ec477da56c8e7b1bc4807d177b43183b9
Close-Bug: #1529007
Display the identity provider panel when the setting
OPENSTACK_KEYSTONE_FEDERATION_MANAGEMENT is set to True.
Change-Id: Iadf92eb7542013f9c212eccfa372c6335a319841
Implements: blueprint keystone-federation-idp
A recent branding effort exposed several aspects of the header
templates that need to be more composable to enable richer
customizations.
The Horizon _header.html template has many components within it:
region pickers, user menus, logos. All of these things are highly
desirable to customize, but because it is all contained in the same
template, a brander will have to override the entire template. This
is not ideal as it increase the cost of maintenance.
The splash section of the login page, the context selector, the logo
section of the header, the user menu and the region selector are now
composable to a much more granular level. The top navigation menus
can now be used outside of existing within a list. The templates
now allow use as normal, standalone dropdown items.
Also, the current primary color used for 'material' was highly
unpleasant with OpenStack Red. Another color on the material design
palette was chosen, very close to the previous blue. See
https://www.google.com/design/spec/style/color.html#color-color-palette
To showcase this new composability, 'material' now shows how to
customize the logo and logo-splash beyond just replacing the png, but
now allowing the use of any type of image. In this case, the
OpenStack logos have been upgraded with their svg counterparts.
It was also noted that the context selection menu was using the wrong
variable to set the color of its links. This was corrected.
Closes-Bug: #1518584
Change-Id: Ib544176b9836e17fc913170664646e1d10eda831
Some useful things are missing from the themeing documentation.
Change-Id: Id128cdb2660fca51c174e0d606225ea8da958924
Partially-Implements: blueprint horizon-theme-css-reorg
Horizon footer is now configurable at a global level and can live
within a theme.
It was noted that the login page will usually want its own footer.
Change-Id: I61d7876b02cbff2d36b076c201847a39b0454136
Closes-bug: #1531335
The settings doc specifies 'alert-error', when horizon uses
'alert-danger'. This causes unexpected behaviour when altering
HORIZON_CONFIG, such as alerts that don't fade (see bug report)
Change-Id: I8e5f3e253db980700f6064264e985ea8cde759d4
Closes-Bug: 1312499
Using scripts inside horizon repo in test hooks we could not bother
infra folks each time when we need to do some change to test job.
The second part of the proposed change is to run these scripts at gate,
see https://review.openstack.org/#/c/263457/
Related-Bug: #1526791
Change-Id: Ic2d60df846e876530662046d75c3e56e7841ba30
Horizon messages (toasts/growls/alerts) now inherit from a theme.
In addition, a default message type was added 'default', since it
it possible to kick up an alert without a type specified at all.
To test all the types, run the following command on a JavaScript
console with Horizon loaded:
horizon.alert('warning', 'foo');
horizon.alert('info', 'foo');
horizon.alert('success', 'foo');
horizon.alert('', 'foo');
horizon.alert('danger', 'foo');
Partially-Implements: blueprint horizon-theme-css-reorg
Partially-Implements: blueprint bootstrap-html-standards
Change-Id: Ice65773fe1d2cdc0305fd01acd8bea3d3f84a9fa
Barcharts were using a complex D3 mechanism to draw very very simple
markup that can be achieved using a simple Bootstrap Stacked Progress
Bar. A templatetag was added to aid in markup reuse.
Also, a 'minifyspace' template helper was also added that enables us
to make templates that have excessive attributes to be more readable,
while not affecting the rendered HTML on the page.
By moving the logic to simple markup, the rendering of the barcharts
are now immediate on the page, instead of requiring Horizon Init
functions to run and draw. This immediate render removes the first
animation on the Quota bars, but it retains animations driven by user
interaction with the forms.
It was hoped that horizon.d3barchart.js could be completely removed,
but it is currently being used by horizon.d3linechart.js. This will
be addressed soon, but was outside of the scope of this patch.
Much of the markup on the Quota pages was cleaned up and made simpler
to use existing style as well as replacing improper usage of <strong>
Summary of Improvements:
* Immediate Render time for Bar Charts
* Bar Charts now Inherit from theme, and use progress bar styles
* 'minifyspace' was added to increase readability to templates
* bs_progress_bar templatetag was added to facilitate code reuse
* Markup for Quota Bar pages refactored
Partially-Implements: blueprint horizon-theme-css-reorg
Partially-Implements: blueprint bootstrap-html-standards
Change-Id: I16a1e3955d3a4fded0f2ea6a87f5e7c2f630185d
In it the Page Object pattern is being explained, as well as various
techniques for debugging a failed integration test.
Change-Id: I3b1da90da9ec0a3fae502f66587cfcf0015e0751
Include various changes for readability. Make bulleted list parallel.
Shorten long sentences. In some cases include articles and clarify
subject in sentences. Spell out "for example." Eliminate redundant
words / phrases. Per Matthias's recommendation, shuffle order of topics
and create two sections to focus first on general packaging principles,
and then Horizon specifics.
Change-Id: Ic864dd926d723c6dc9749249655ae2e7d08ed225
Co-Authored-By: Matthias Runge <mrunge@redhat.com>
Closes-Bug: #1516986
Launchpad URL is useful when reporting or finding bugs.
Some repositories have no pointer to bug tracking systems.
Change-Id: I1f72273f8c7f83b93e69fd153db6ec1d976a7b95
After some discussion on a patch and in room with Doug,
we determined that we should make the guidance for release notes
more strongly suggest providing release notes in the same
patch as the changes being introduced.
Change-Id: Ifa8e8e9b01fafaa0a7e3e12b0052e4f8d5554e58
Allows to config the api version to use on the local_settings
through OPENSTACK_API_VERSIONS.
Updates docs and local_settings.py.example.
Defaults to version 2.
Closes-Bug: 1497056
Change-Id: If9ec4dcdd79baeec105dbe3ec5345b7d6cf1dc10
Signed-off-by: Itxaka <iserrano@redhat.com>
This patch enables the PhantomJS webdriver for running
the Selenium test suite.
Use it with the --selenium-phantomjs command-line switch
when executing the selenium and integration suite.
Change-Id: I443e6f6d7d1911df500b360f7c22686b417fbeae
Blueprint: enable-phantomjs-selenium
Tabs were pretty basic. For the most, tabs were using the standard
styles nicely, except when embedded inside of a modal. There was a
lot of adding padding and removing padding to the tab-content and
modal container. This has been cleaned up.
Also, the 'asterisk' that is used to show when a tab has required
information for a workflow was changed to an icon font.
Many unused styles were removed from horizon.scss.
Partially-Implements: blueprint horizon-theme-css-reorg
Partially-Implements: blueprint bootstrap-html-standards
Change-Id: I929de0ae31a3c2cca9e332956eed755c4e279f3d
Since we added support for reno, document that submitters should
provide release notes with their changes. Rather than expecting
others to provide them at the end.
Change-Id: I787f37c9a748774b01cea08da38d91d62de96dd1
The Horizon login page was not properly inheriting its styles from
its theme. The implementation was making use of the _modal_form.html
template just to inherit a form, but there was no way to remove
the modal classes with that implementation.
The login page now uses a standard Bootstrap 'panel'. This will
inherit the look and feel of any theme more naturally when its not
inside of a modal, as not all themes use box-shadow outside of a
modal; some chose to be very flat on purpose, and the built in
panels take advantage of this.
When used within the Region selector, it does need to exist within
a modal, so some simple logic was added for the classes necessary.
The panel is a little bit wider than it was before, but it is now
a standard Bootstrap column size, so its responsive down to a very
small screen size.
The modal is a little bit wider than it was before as well, as it is
is now the standard medium modal size for Bootstrap.
Improvements:
* Logo is now an <img> tag, which means it can automagically resize
to fit in the available space
* Unneccesary styles removed
* _splash.scss was only being used in _login.html, which was
confusing, so _splash.scss is renamed to _login.scss, and is now a
class based style, so it can live in /components
* Its now Theme ready and responsive
* Region Selector Login now has a proper modal backdrop
* has-error help-text should not be alert alert-danger
Partially-Implements: blueprint horizon-theme-css-reorg
Partially-Implements: blueprint bootstrap-html-standards
Change-Id: Ie968414ab8ef2154623edfc21ce5623e8c4057c6
This patch adds a topic guide explaining how developers should write and
organise SCSS within Horizon.
Change-Id: I4de2d1da73f6c7977a16fba9d09678923d7c443c
Closes-Bug: 1514869
Horizon tables had many hardcoded padding and colors in them, which
made them not theme-ready. This patch vets all the old table styles
for their current usage (if any) and reimplemented the necessary
rules to inherit from the theme.
There were a number of styles that were obviously not being used any
longer. These rules were removed. There were also many rules that
were very difficult to determine their lineage, as the scss lacks
much needed commentary on why some styles exist (if they are working
around specific browser issues, or usability glitches, etc).
A few examples of some of these removed styles include:
* th.narrow
* td.select
* th span.required:after
This patch does not include refactor of the dropdowns or inline edit.
Immediate Improvements:
* Table Actions are now all consistent heights
* The cursor is a pointer ONLY on sortable rows now
* The column sort indicator is now an icon font, therefore high def
* table_header height no longer hardcoded, can grow with theme
* Slow waiting cursor style using global selector * removed
* Many dead styles were removed!!
* Hovering on status_unknown rows now keeps proper color
Partially-Implements: blueprint horizon-theme-css-reorg
Partially-Implements: blueprint bootstrap-html-standards
Change-Id: I4a904704926dc50010ad480539db828eff559fa0
A number of components of Horizon have been made theme-ready, but proper
documentation needs to follow to provide guidance of how to make use of
this new feature.
Change-Id: I8c95801eb0bfa6bd1692c794536e292c5478dd3d
Partially-Implements: blueprint horizon-theme-css-reorg
