Fixes all occurrences of this. We have a custom exception handler
in Horizon anyway that only catches ClientException in most of these
cases, but this commit lets us gate on the other cases.
Change-Id: Iea3dc13817f3e5b775b2024424bf3a906da5584b
Closes-Bug: #1211657
This is talked in bug #1188533, and in current codes, there are several
places here:
horizon/forms/__init__.py:18:from django.forms import *
mark '# noqa'
openstack_dashboard/settings.py:182: from local.local_settings import *
openstack_dashboard/test/settings.py:5:from horizon.test.settings import *
mark '# noqa'
openstack_dashboard/dashboards/project/instances/workflows/__init__.py:1:from create_instance import *
openstack_dashboard/dashboards/project/instances/workflows/__init__.py:2:from update_instance import *
openstack_dashboard/dashboards/project/instances/workflows/__init__.py:3:from resize_instance import *
fix it
openstack_dashboard/dashboards/project/images_and_snapshots/urls.py:21:from django.conf.urls.defaults import *
fix it
fixes bug # 1188533
Change-Id: Id671280903f8452a78f81f1240d92297de7a89a8
This check looks to see whether a local variable
is unused. Also fixed all violators of said check.
Change-Id: I7c186df41b5601078ffc54588aace8136c6576bd
This patch replaces relative imports with full paths and
makes H304 test enabled.
Fixes bug 1188535
Change-Id: I47254cf9a790727102f7993d0fd107da514983df
Introduce py33 to tox.ini to make testing
easier with python3.
Change-Id: Ie642f154879d36fda856fb9917c7784f93711594
Signed-off-by: Chuck Short <chuck.short@canonical.com>
This patch also re-organizes imports to import one per line.
Change-Id: Ia958e3a30a48d4308d08d51df243c1272425c316
Fixes: bug 1188529
Fixes: bug 1188537
In the move to make flake8 tests stricter, we need a code
cleanup earlier.
This removes all unused imports and also enables tests to prevent
them for the future.
This patch also includes the checks on __init__.py files.
Change-Id: I34055803f7c4726682ac6fb95cc5b50ba761fec8
Fixes: bug 1188134
Add HACKING.rst but instead of copying the file around point to the new
cannonical location for it
https://github.com/openstack-dev/hacking/blob/master/HACKING.rst
Also expand out the flake8 H series ignores, so they can be enabled one
by one.
Change-Id: I6ec39d00c3beabbc3e661754bac6e43a0fb351d6
and tools/test-requires to test-requirements.txt
These are standard files and tools in the
general world are growing intelligence about them.
Change-Id: Iac3c680dd19cabd8ea38598a6e2bb27238030a2d
Fixes: bug #1179008
Horizon is the last project that doesn't have support for the common
Project Testing Interface. This gets horizon up to speed with the
other bits, but shouldn't break any of the existing interfaces.
Change-Id: I464c3b10d9708a0b7b5ffd42c88cd3cf515ef6a7
