openstack/horizon
Code Issues Proposed changes
7,941 Commits 10 Branches 56 Tags
9732709deb
Commit Graph

6 Commits

Author SHA1 Message Date
Thai Tran
b4e92f7273 Jshint removing Hogan and static_url 
Hogan and STATIC_URL are only use in a few files. Hence, we do not really
need them enabled globally. Removing them from jshint global config.

Change-Id: I0881ab0e6668a47bf795e422e17f9f025a010d31
Closes-bug: #1452464
 2015-05-06 14:34:08 -07:00
Thai Tran
328cd20a1b Adding unused, undef, and fail to jshint 
Adding detection for unused variables for general code cleanup.
Adding detection for using undefined variables for spotting
leaking and mistyped variables.

Also cleaned remaining files.

Change-Id: I5cc4e3168c0836a56e7799f589e384241168354f
Closes-bug: #1438620
 2015-04-28 09:15:33 -07:00
Thai Tran
9f8c35c9e4 Adding Hogan and Qunit globals to jshint 
Since we are cleaning up legacy, we need to add additional globals to jshint.
These globals include some 3rd party libraries like Hogan and Qunit.

Change-Id: I4165b7b4f669ca8f5bd7136ba0e2f58f526d7f4c
Partial-bug: #1438620
 2015-04-23 03:02:10 +00:00
Thai Tran
1fa042f233 Adding horizon to jshint 
Suppressing error by adding horizon to global jshint configuration.

Change-Id: Ibd7d0262255a567a1e0c9efcc25bd32a8a3f86b4
Closes-bug: #1441780
 2015-04-08 18:08:06 +00:00
Thai Tran
fc997424ea Adding spyOn and jasmine to global jshint 
Suppressing error by adding spyOn to global jshint configuration.

Closes-bug: #1435436
Co-Authored-By: Shaoquan Chen <sean.chen2@hp.com>
Change-Id: If18edd2a28d77b420fb4ce77a4da97f03b8690b4
 2015-03-23 14:23:01 -07:00
Shaoquan Chen
46b6a3b047 Improving jshint 
- Including JS files under horizon/static/angular/ folder.
- Adding .jshintrc to allow globals defined by jQuery, Angular,
  Angular mock, Jasmine, d3 and jsi18n.
- Allowing global strict mode in spec files.

Change-Id: I07359a4b3044cd5f675eef3b7df99398df909f81
Closes-Bug: #1419625
 2015-02-13 13:19:56 -08:00