This changes the run of tox with cover, to just ammend cover
output data.... the combine option seemed to be breaking the data
and then the xml / html options did not work as a result.
Change-Id: Ic600b55855cf74c1b6ed138fea5c4b7bb037de82
Closes-bug: #1628661
Issues fixed:
* Fixes issue where text entry is borked when clicking to make a new facet
* No ‘x’ icon when text search only
* Text search, then click “x”, text search NOT removed and search result not updated
* Text search, then click facet, text hidden but still used
* Text search, then select a facet, hit main “x”, only facet removed, text search
NOT removed
* text search, enter to make text facet, then “x”, then select a “Type” “Image” facet,
then the text facet reappears, then “x” again and Image facet cleared but text facet
remains
Change-Id: I3f00836684fade0f1050d180a44924af48e3d868
Closes-Bug: 1628588
Cinder currently expose an api to let the users update the volumes
metadata so horizon should expose this functionality.
The metadata is filtered to remove image metadata attributes. There is
work in progress (in Cinder) that will expose the ability to
write-through image metadata to underlying images where appropriate.
Allowing setting of image properties in this UI would be confusing.
Change-Id: If721ac1c908df7651d630f6e7d36f2cc4d69f5da
Implements: blueprint ability-to-add-metadata-to-cinder-volumes-and-snapshots
Co-Authored-By: Santiago Baldassin <santiago.b.baldassin@intel.com>
Co-Authored-By: Pawel Skowron <pawel.skowron@intel.com>
Co-Authored-By: Bartosz Fic <bartosz.fic@intel.com>
Co-Authored-By: Pawel Koniszewski <pawel.koniszewski@intel.com>
Co-Authored-By: Michal Dulko <michal.dulko@intel.com>
Co-Authored-By: David Lyle <david.lyle@intel.com>
Co-Authored-By: Paul Karikh <pkarikh@mirantis.com>
The 9-th line of horizon/openstack_dashboard/
local/local_settings.py.example imports exceptions
module. But this module is unused in code and doesn't
described in comment lines.
Change-Id: I9568ba7d33b797cd91f9a50bf5162d305c1e078d
The lib file term.js has been moved into a subfolder 'termjs'.
So the link path of this file should be updated too.
Change-Id: I022c84e4e5bf7935db157af40a306a477291e36a
Closes-Bug: #1623799
There are some place being displayed unnecessary bullet point.
- Error message in login page (This ticket has a screenshot).
There is no need to use 'ul'.
- The row of 'No users/groups' in Project Member/Group tab in
Create/Update Project modal.
- The row of 'No projects found' in Flavor Access tab in
Edit Flavor modal.
There are same structure as a membership. So it needs to
add a nav class.
This patch fix it.
Change-Id: I3f906808a53807ebd8c0d6a342b0219383776e91
Closes-bug: #1617262
Container details styles are currently broken. The container
details are being displayed as a bulleted list which is wrong
this patch fixes that.
Change-Id: I986a326ff25ade0fedb8811a10c0edad9cbbcdac
Closes-Bug: #1624562
Indonesian translation have made a significant progress
during Newton cycle. Let's add it to the language list
in openstack_dashboard.settings so that Indonesian is listed
by the language pull-down menu by default.
I am planning to make this process automated in near future
(hopefully in Ocata cycle).
Change-Id: Iacbf112df81ee1b4fc40c063eaaa7d0b1c92ca7a
Closes-Bug: #1627673
Originally, 'Displaying x items' is included in footer area.
However, the element that the previous patch added is not in this area.
Thus, when the number of rows in table is zero, this behaviour is difference
(the element at the bottom of the table is hide, but the element
at the top of the table remain displaying).
I think these should be same behaviour as a footer information.
Change-Id: I6eb10db2bf00c8686c0df9d990787a2a890e6340
Related-Bug: #1359238
A log on button name in horizon depends on auth_type.
This patch will fix it so as to be displayed without a flicker
after evaluation is finished.
Change-Id: I174716651ea2f4ac894c7dd5d52e5f57fe8be06a
Closes-Bug: #1627560
When OperationLogMiddleware was introduced,the existing HorizonMiddleware
was moved under horizon/middleware/ directory.
As a result, doc/source/ref/middleware.rst generates nothing now.
This commit updates the doc/source/ref/middleware.rst to
include both middlewares.
Change-Id: Ie308fd20e7fec6b70a72e7f2b7f04dcfef6568df
Due to tricky behavior of gettext, if we have both normal
gettext string and plural gettext string for a same string,
the normal gettext string is not translated.
(The detail is described in the bug report. See comment #5.)
As a workaround, this commit adds a context information to
the plural gettext string in volumes.volumes.tables.DetachVolume
so that we can have separate entries for a normal entry and
an entry with plural form support. By doing so, gettext can
find an expected translated string for a normal string.
After this change, we will see the following entries
for "Detach Volume" in the generated PO file.
----
msgid "Detach Volume"
msgstr ""
msgctxt "Action to perform (the volume is currently attached)"
msgid "Detach Volume"
msgid_plural "Detach Volumes"
msgstr[0] ""
msgstr[1] ""
----
Note that the message "Detaching Volume" for the post action
in the table is also updated to use npgettext_lazy.
This and "Detach Volume" are a pair, so it looks better to
use a same style.
Change-Id: Idf772265d3e0e1d2e74b19755a467e1433233f64
Closes-Bug: #1626312
Also sorts boot source options in the order of the dropdown menu
of "Select Boot Source".
Change-Id: Icc9796123afe84af9dc1e8fc27cb56dd83a7a5d3
Closes-Bug: #1626302
Use -W (turn warnings into errors) option of sphinx-build
in the commandline of 'docs' tox target so that developer
can easily check sphinx warning.
Also runs the same documentation check in 'pep8' tox target
to detect sphinx warning in the gate.
The current 'docs' job in the gate does not use 'tox -edocs'
intentionally and calls build_sphinx via 'tox -evenv' [1],
so sphinx warnings are not detected in the 'docs' job.
Note that we no longer generate the whole code reference so this
change does not increase the time of 'tox -epep8' much,
while we can prevent new sphinx warnings.
[1] 6b50d7e3a6/jenkins/scripts/run-docs.sh (L16-L19)
Closes-Bug: #1411719
Closes-Bug: #1486222
Change-Id: Idc6e8a1c5762eba113b2d110d5fa223ab7406be3
horizon devref has both explicit autodoc directives and
automatically generated source references.
This causes a lot of 'WARNING: duplicate object description'.
I think that we don't need source code references for most modules
and it is better to have explicit API references of modules
for which we need references. Thus this commit removes the logic
to generate source references.
This contributes a lot to reduce the number of sphinx warnings.
Also reduces the required time of documentation build :-)
Partial-Bug: #1411719
Partial-Bug: #1486222
Change-Id: Iba2bf3723cad159f4cfd1fff47e8114d9867e040
Added a reusable pagination template that is now applied to the top
and bottom of the data_table.
Change-Id: I7eb040b9c08fef984d20c8dba560cfe0c8be8cac
Closes-bug:#1359238
A previous patch altered the defaults in the angular Launch Instance,
but didn't account for those running without Cinder. This patch fixes
those assumptions.
Co-Authored-By: Rob Cresswell <robert.cresswell@outlook.com>
Change-Id: I8dc54fa40fa7eb8ae95a13741405f2a80337b33d
Closes-Bug: 1585761
This patch moves the developer panel enabled files to contrib, to stop
any strange behaviour when interacting with settings from enabled files
and prevent warning logs when DEBUG is False.
Change-Id: If7a2d023afe418b6dd90edf8a4a1d3bc9646c7ad
This patch represents the following patches, combined:
---
integration tests: retry WebDriver instantiation when conn refused
https://review.openstack.org/#/c/375042/
We see connection refused which leads to integration test failure randomly.
This seems to come from high load of test infra. This commit retries
WebDriver instantiation when connection refused is returned.
There is no confident this workaround works, but it would be great
if this reduces the number of failures. Let's try.
---
integration test: ensure IPv4 address is extracted
https://review.openstack.org/#/c/374826/
In test_floatingip_associate_disassociate, IPv6 address is passed
to Floating IP associate API. This commit ensures to pick up IPv4
address of an instance.
Change-Id: Iba71d1e17e252527a82cd53c34dca35723367b28
Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Partial-Bug: #1626643
Closes-Bug: #1626536
If a user use current example[1] as is, other attributes that
HORIZON_CONFIG have are eliminated. As a result, some unexpected
behavior may occur. So, this patch modify the exapmle.
[1]:http://docs.openstack.org/developer/horizon/topics/customizing.html
Change-Id: I022a73e6da6ad9b8ae1f807838cf29efedf7e1ef
Closes-Bug: #1626858
This fixes the case where known metadata types were not being removed
upon saving. When trying to apply name changes to the provided value,
the work was done out of order, causing the item to be taken out
of the 'removed' list.
Change-Id: I0058ce369a9616b4c49f3d6d1a54cf69144e2f0c
Co-Authored-By: Matt Wood <matt.wood@hpe.com>
Closes-Bug: 1618578
The RemoveVIPFloatingIP.single method was deleting a floating IP and
then displayed a message about another floating IP.
Change-Id: Ic6078299ddb34550c002218aad28d05907827b01
Closes-bug: #1625639
admin.volumes.volumes.tests.VolumeViewTests uses LBaaS pool data as
a result of api.cinder.pool_list(). cinder_pools data should be used.
Change-Id: I251c6dffcbaf19a2d8d173f06e0e8979a0ceee0b
Don't rely on a particular workspace name, as it changes when job's
name changes.
Depends-On: I28d84235fb51a49492ed9c96794ba74f317f66b6
Change-Id: I63e45ee89711b429d0d878303aefeec4b159125a
Closes-Bug: #1625253
