openstack/horizon
Code Issues Proposed changes
OpenStack Dashboard (Horizon)
10,390 Commits 10 Branches 54 Tags 311 MiB
Python 63.1%
JavaScript 28.8%
HTML 6.5%
SCSS 1.5%
0b4b2976af
Go to file
Suraj Deshmukh 0b4b2976af ICMP type & code validation while adding Security Group rules 
While adding new 'Security Group Rule' viz. 'Custom ICMP rule' when
wrong ICMP 'type' or 'code' was given the errors it would show were
'Not a valid port number'; which is misleading. The errors should
rather be 'Not a valid ICMP type' or 'Not a valid ICMP code'.

Also for validating ICMP 'type' and 'code' there wasn't any dedicated
functionality in 'oslo.utils/netutils' so the code for validating 'TCP
ports' was used. TCP ports are in range 0 to 65535 while ICMP 'type'
and 'code' are in range 0 to 255, so using 'TCP port validation' code
is incorrect.

When -1 is used in 'ICMP code' or 'ICMP type' that means any number
0 to 255 is valid.

Here newer dedicated functionality of 'oslo.utils/netutils' is used
for validating ICMP 'type' and ICMP 'code'.

Change-Id: I8e227a0021d418294fa7b7756d58e39f2100850a
Closes-Bug: #1511748
(cherry picked from commit edfde8b3f5)
2016-06-20 15:43:57 +00:00
doc Merge "Deprecate default_*_subnet_pool_label options" 2016-03-04 22:21:26 +00:00
horizon ICMP type & code validation while adding Security Group rules 2016-06-20 15:43:57 +00:00
openstack_dashboard ICMP type & code validation while adding Security Group rules 2016-06-20 15:43:57 +00:00
releasenotes Merge "Adding missing release notes around upgrades" 2016-03-18 03:51:56 +00:00
tools Hotfix the issue with too new Firefox version 2016-06-16 08:35:41 +02:00
.eslintignore Added .eslintignore 2015-07-02 08:29:08 -07:00
.eslintrc Merge "Enable "no-new" and "guard-for-in"" 2016-01-31 09:55:18 +00:00
.gitignore Enable Angular Launch Instance by default 2016-03-03 17:40:35 +00:00
.gitreview Update .gitreview for stable/mitaka 2016-03-18 13:51:36 -04:00
.mailmap Update my mailmap 2013-10-25 14:49:23 +08:00
.pylintrc updating run_tests.sh to mimic other openstack projects, pep8, pylint, coverage 2011-08-31 14:41:36 -07:00
.testr.conf Add testr support 2015-12-10 09:45:41 +01:00
babel-django.cfg Added a django extract for .csv files 2015-09-15 21:57:42 +00:00
babel-djangojs.cfg Angular translation via babel (singular only) 2015-07-02 11:13:45 +10:00
CONTRIBUTING.rst Workflow documentation is now in infra-manual 2014-12-05 03:30:36 +00:00
HACKING.rst Eliminate mutable default arguments 2015-12-17 09:58:46 +00:00
LICENSE Initial commit 2011-01-12 13:43:31 -08:00
Makefile Unifies the project packaging into one set of modules. 2012-02-29 00:20:13 -08:00
manage.py Gate on H102 Apache 2.0 license header not found for pep8 2013-11-19 13:55:04 -05:00
MANIFEST.in Update MANIFEST for SCSS 2015-09-09 14:42:10 +01:00
package.json Use Chrome for JS unit tests 2016-04-19 15:35:25 +00:00
README.rst Add install guide for users and clean up README 2014-10-09 03:29:26 +09:00
requirements.txt Updated from global requirements 2016-05-15 18:01:52 +00:00
run_tests.sh Fix translation test 2016-05-10 00:33:16 +00:00
setup.cfg Removing version line from setup.cfg 2015-12-03 11:55:21 -07:00
setup.py Updated from global requirements 2015-09-19 05:37:19 +00:00
test-requirements.txt Updated from global requirements 2016-02-11 14:46:21 +00:00
test-shim.js Fix bug where WEBROOT is not respected 2015-07-22 04:10:50 +00:00
tox.ini Port last unit tests to Python 3 2016-02-10 18:22:52 +01:00

README.rst

Horizon (OpenStack Dashboard)

Horizon is a Django-based project aimed at providing a complete OpenStack Dashboard along with an extensible framework for building new dashboards from reusable components. The openstack_dashboard module is a reference implementation of a Django site that uses the horizon app to provide web-based interactions with the various OpenStack projects.

Using Horizon

See doc/source/topics/install.rst about how to install Horizon in your OpenStack setup. It describes the example steps and has pointers for more detailed settings and configurations.

It is also available at http://docs.openstack.org/developer/horizon/topics/install.html.

Getting Started for Developers

doc/source/quickstart.rst or http://docs.openstack.org/developer/horizon/quickstart.html describes how to setup Horizon development environment and start development.

Building Contributor Documentation

This documentation is written by contributors, for contributors.

The source is maintained in the doc/source directory using reStructuredText and built by Sphinx

  • Building Automatically:

    $ ./run_tests.sh --docs

  • Building Manually:

    $ tools/with_venv.sh sphinx-build doc/source doc/build/html

Results are in the doc/build/html directory