1f80d94459
Nose has been in maintenance mode for the past several years. It has issue with exit code [1] which leads to false positive results for our seleniun-headless job. This patch changes test runner for Horizon tests and does the following things: * Django test runner executes test in a different order than Nose does. That's why we've got an issue with side-effect in horizon.tests.unit.tables.test_tables.MyToggleAction class. This patch adds workaround to it. * Rename filename of test files to names starting with 'test_' so that the django test runner can find tests expectedly. * '--with-html-output' option is temporary dropped and will be added in a following patch. * Integraion tests is marked via django.test.tag mechanism which is introduced in Django 1.10 * 'selenium-headless' is broken now because we don't have geckodriver on gates, this patch makes it non-voting. * 'tox -e cover' is fixed * Remove @memorized decorator from dashboards.project.images.images.tables.filter_tenant_ids function. [1] https://github.com/nose-devs/nose/issues/984 Depends-On: https://review.openstack.org/572095 Depends-On: https://review.openstack.org/572124 Depends-On: https://review.openstack.org/572390 Depends-On: https://review.openstack.org/572391 Related blueprint: improve-horizon-testing Change-Id: I7fb2fd7dd40f301ea822154b9809a9a07610c507
109 lines
4.5 KiB
Python
109 lines
4.5 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import unittest
|
|
|
|
import mock
|
|
|
|
from openstack_dashboard.api import microversions
|
|
|
|
|
|
class _VersionWrapper(object):
|
|
|
|
def __init__(self, version):
|
|
self.version = version
|
|
|
|
def matches(self, min_ver, max_ver):
|
|
return min_ver <= self.version <= max_ver
|
|
|
|
|
|
class MicroversionsTests(unittest.TestCase):
|
|
|
|
def _test_get_microversion(self, min_ver, max_ver,
|
|
features=None, service=None,
|
|
feature_versions=None):
|
|
if feature_versions is None:
|
|
feature_versions = {'myservice': {'feature_a': ['2.3', '2.5']}}
|
|
if features is None:
|
|
features = ['feature_a']
|
|
if service is None:
|
|
service = 'myservice'
|
|
with mock.patch.object(microversions, 'MICROVERSION_FEATURES',
|
|
feature_versions):
|
|
return microversions.get_microversion_for_features(
|
|
service, features, _VersionWrapper, min_ver, max_ver)
|
|
|
|
def test_get_microversion(self):
|
|
ret = self._test_get_microversion('2.1', '2.5')
|
|
self.assertIsInstance(ret, _VersionWrapper)
|
|
self.assertEqual('2.5', ret.version)
|
|
|
|
def test_get_microversion_second_version(self):
|
|
ret = self._test_get_microversion('2.1', '2.4')
|
|
self.assertIsInstance(ret, _VersionWrapper)
|
|
self.assertEqual('2.3', ret.version)
|
|
|
|
def test_get_microversion_out_of_range(self):
|
|
ret = self._test_get_microversion('2.1', '2.2')
|
|
self.assertIsNone(ret)
|
|
|
|
def test_get_microversion_string_feature(self):
|
|
ret = self._test_get_microversion('2.1', '2.5', 'feature_a')
|
|
self.assertIsInstance(ret, _VersionWrapper)
|
|
# NOTE: ret.version depends on a wrapper class.
|
|
self.assertEqual('2.5', ret.version)
|
|
|
|
def test_get_microversion_multiple_features(self):
|
|
feature_versions = {'myservice': {'feature_a': ['2.3', '2.5', '2.7'],
|
|
'feature_b': ['2.5', '2.7', '2.8']}}
|
|
ret = self._test_get_microversion(
|
|
'2.1', '2.9', ['feature_a', 'feature_b'],
|
|
feature_versions=feature_versions)
|
|
self.assertIsInstance(ret, _VersionWrapper)
|
|
self.assertEqual('2.7', ret.version)
|
|
|
|
def test_get_microversion_multiple_features_second_largest(self):
|
|
feature_versions = {'myservice': {'feature_a': ['2.3', '2.5', '2.7'],
|
|
'feature_b': ['2.5', '2.7', '2.8']}}
|
|
ret = self._test_get_microversion(
|
|
'2.1', '2.6', ['feature_a', 'feature_b'],
|
|
feature_versions=feature_versions)
|
|
self.assertIsInstance(ret, _VersionWrapper)
|
|
self.assertEqual('2.5', ret.version)
|
|
|
|
def test_get_microversion_multiple_features_out_of_range(self):
|
|
feature_versions = {'myservice': {'feature_a': ['2.3', '2.5', '2.7'],
|
|
'feature_b': ['2.5', '2.7', '2.8']}}
|
|
ret = self._test_get_microversion(
|
|
'2.1', '2.4', ['feature_a', 'feature_b'],
|
|
feature_versions=feature_versions)
|
|
self.assertIsNone(ret)
|
|
|
|
def test_get_microversion_multiple_features_no_common_version(self):
|
|
feature_versions = {'myservice': {'feature_a': ['2.3', '2.5', '2.7'],
|
|
'feature_b': ['2.6', '2.8']}}
|
|
ret = self._test_get_microversion(
|
|
'2.1', '2.9', ['feature_a', 'feature_b'],
|
|
feature_versions=feature_versions)
|
|
self.assertIsNone(ret)
|
|
|
|
def test_get_microversion_version_number_sort(self):
|
|
feature_versions = {'myservice': {'feature_a': ['2.3', '2.20', '2.2']}}
|
|
ret = self._test_get_microversion('2.1', '2.30',
|
|
feature_versions=feature_versions)
|
|
self.assertIsInstance(ret, _VersionWrapper)
|
|
self.assertEqual('2.20', ret.version)
|
|
|
|
def test_get_microversion_undefined_service(self):
|
|
ret = self._test_get_microversion('2.1', '2.5', service='notfound')
|
|
self.assertIsNone(ret)
|