openstack
/
horizon
Code Issues Proposed changes
horizon/openstack_auth
History
Mathieu Gagné 6ae1f5e21d Fix django.contrib.auth.middleware monkey patching 
The "request" attribute is not available in
openstack_auth.backend.KeystoneBackend.get_user when session data is restored
and it's the first request to happen after a server restart.

As stated by the function document, the "request" attribute needs to be
monkey-patched by openstack_auth.utils.patch_middleware_get_user
for this function to work properly.

This should happen in openstack_auth.urls at import time. But there is nowhere
in Horizon where this module is imported at startup. It's only introspected
by openstack_dashboard.urls due to AUTHENTICATION_URLS setting.

Without this monkey-patching, the whole authentication mechanism falls back
to "AnonymousUser" and you will get redirected to the login page due
to horizon.exceptions.NotAuthenticated being raised by
horizon.decorators.require_auth as request.user.is_authenticated will be False.

But if a user requests a page under auth/, it will have the side-effect of
monkey-patching django.contrib.auth.middleware as expected. This means that
once this request is completed, all following requests to pages other than
the ones under auth/ will have there sessions properly restored and
you will be properly authenticated.

Therefore this change introduces a dummy middleware which sole purpose is
to perform this monkey-patching as early as possible.

There is also some cleanup to get rid of the previous attempts at
monkeypatching.

Closes-bug: #1764622

[backport specific notice]
Queens horizon supports Django 1.8 and 1.11.
The key point is Django 2.0 is not supported.
Django 2.0 dropped the legacy Django middleware interface and
the new interface is not supported in Django 1.8.
Thus, this backport changes OpenstackAuthMonkeyPatchMiddleware in
openstack_auth/middlware.py to use the legacy middleware interface.

Conflicts:
	openstack_dashboard/settings.py
	openstack_dashboard/test/helpers.py

Change-Id: Ib9912090a87b716e7f5710f6f360b0df168ec2e3
(cherry picked from commit 0d16361326)
(cherry picked from commit 8851866aad)
 		2018-11-20 23:29:58 +09:00
..
locale Imported Translations from Zanata 2018-04-17 07:35:44 +00:00
plugin Correct odd exception message 2018-01-30 13:11:31 +09:00
tests Fix django.contrib.auth.middleware monkey patching 2018-11-20 23:29:58 +09:00
__init__.py Add Django OpenStack Auth to Horizon 2017-09-27 12:06:57 +01:00
backend.py Add Django OpenStack Auth to Horizon 2017-09-27 12:06:57 +01:00
exceptions.py Add Django OpenStack Auth to Horizon 2017-09-27 12:06:57 +01:00
forms.py Add user_domain_name to logs regarding authentication 2017-11-24 21:12:23 +00:00
middleware.py Fix django.contrib.auth.middleware monkey patching 2018-11-20 23:29:58 +09:00
models.py Add Django OpenStack Auth to Horizon 2017-09-27 12:06:57 +01:00
policy.py Fix api.keystone.is_cloud_admin/is_domain_admin handling with new policies 2018-01-17 15:14:33 +01:00
urls.py Fix django.contrib.auth.middleware monkey patching 2018-11-20 23:29:58 +09:00
user.py Add Django OpenStack Auth to Horizon 2017-09-27 12:06:57 +01:00
utils.py Fix django.contrib.auth.middleware monkey patching 2018-11-20 23:29:58 +09:00
views.py Horizon UI message when browser cookies disabled 2018-01-29 07:58:41 +00:00