a212ef399f
A network operation can fail because of different reasons - yet in many places just one error message is provided. Combined with too broad exception clause, and incorrect assumptions on the reasons of failure (e.g. Neutron service being unavailable causes all other sorts of errors like inability to Allocate IP or Associate it) this leads to multiple errors when just one would suffice. The fix aims to provide sensible error messages in case the network service is down. This includes returning only unique messages in a single response. Partial-Bug: #1301374 Change-Id: Id6c620ca51f7703f35c0c172e39fdf237fa42278 Co-Authored-By: Timur Sufiev <tsufiev@mirantis.com>
76 lines
2.7 KiB
Python
76 lines
2.7 KiB
Python
# Copyright 2012 United States Government as represented by the
|
|
# Administrator of the National Aeronautics and Space Administration.
|
|
# All Rights Reserved.
|
|
#
|
|
# Copyright 2012 Nebula, Inc.
|
|
# Copyright (c) 2012 X.commerce, a business unit of eBay Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
Views for managing floating IPs.
|
|
"""
|
|
|
|
from django.core.urlresolvers import reverse_lazy
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
from neutronclient.common import exceptions as neutron_exc
|
|
|
|
from horizon import exceptions
|
|
from horizon import forms
|
|
from horizon import workflows
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.usage import quotas
|
|
|
|
from openstack_dashboard.dashboards.project.access_and_security.\
|
|
floating_ips import forms as project_forms
|
|
from openstack_dashboard.dashboards.project.access_and_security.\
|
|
floating_ips import workflows as project_workflows
|
|
|
|
|
|
class AssociateView(workflows.WorkflowView):
|
|
workflow_class = project_workflows.IPAssociationWorkflow
|
|
|
|
|
|
class AllocateView(forms.ModalFormView):
|
|
form_class = project_forms.FloatingIpAllocate
|
|
template_name = 'project/access_and_security/floating_ips/allocate.html'
|
|
success_url = reverse_lazy('horizon:project:access_and_security:index')
|
|
|
|
def get_object_display(self, obj):
|
|
return obj.ip
|
|
|
|
def get_context_data(self, **kwargs):
|
|
context = super(AllocateView, self).get_context_data(**kwargs)
|
|
try:
|
|
context['usages'] = quotas.tenant_quota_usages(self.request)
|
|
except Exception:
|
|
exceptions.handle(self.request)
|
|
return context
|
|
|
|
def get_initial(self):
|
|
try:
|
|
pools = api.network.floating_ip_pools_list(self.request)
|
|
except neutron_exc.ConnectionFailed:
|
|
pools = []
|
|
exceptions.handle(self.request)
|
|
except Exception:
|
|
pools = []
|
|
exceptions.handle(self.request,
|
|
_("Unable to retrieve floating IP pools."))
|
|
pool_list = [(pool.id, pool.name) for pool in pools]
|
|
if not pool_list:
|
|
pool_list = [(None, _("No floating IP pools available"))]
|
|
return {'pool_list': pool_list}
|