754585d67b
When trying to get a PanelGroup at runtime and you specify a nonregistered panel, a KeyError is thrown when calling Dashboard.get_panel_group. Retrieving values from a Dict using the [] formulation results in a KeyError for non existent keys. Using Dict#get returns None for non existent keys which is what this change does. This is relevant to the dynamic panel efforts going on. Closes-Bug: 1396682 Change-Id: I532c3be04fdd229dfd8e01b68320b2eecb6fd866
57 lines
2.1 KiB
Python
57 lines
2.1 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import copy
|
|
|
|
from django.conf import settings
|
|
from django.test.utils import override_settings
|
|
|
|
import horizon
|
|
|
|
from openstack_dashboard.test import helpers as test
|
|
from openstack_dashboard.test.test_panels.plugin_panel \
|
|
import panel as plugin_panel
|
|
import openstack_dashboard.test.test_plugins.panel_group_config
|
|
from openstack_dashboard.utils import settings as util_settings
|
|
|
|
|
|
PANEL_GROUP_SLUG = 'plugin_panel_group'
|
|
HORIZON_CONFIG = copy.deepcopy(settings.HORIZON_CONFIG)
|
|
INSTALLED_APPS = list(settings.INSTALLED_APPS)
|
|
|
|
# NOTE: Ensure dashboards and default_dashboard are not included in
|
|
# HORIZON_CONFIG to ensure warning messages from update_dashboards below.
|
|
HORIZON_CONFIG.pop('dashboards', None)
|
|
HORIZON_CONFIG.pop('default_dashboard', None)
|
|
|
|
util_settings.update_dashboards([
|
|
openstack_dashboard.test.test_plugins.panel_group_config,
|
|
], HORIZON_CONFIG, INSTALLED_APPS)
|
|
|
|
|
|
@override_settings(HORIZON_CONFIG=HORIZON_CONFIG,
|
|
INSTALLED_APPS=INSTALLED_APPS)
|
|
class PanelGroupPluginTests(test.PluginTestCase):
|
|
def test_add_panel_group(self):
|
|
dashboard = horizon.get_dashboard("admin")
|
|
self.assertIsNotNone(dashboard.get_panel_group(PANEL_GROUP_SLUG))
|
|
|
|
def test_add_panel(self):
|
|
dashboard = horizon.get_dashboard("admin")
|
|
self.assertIn(plugin_panel.PluginPanel,
|
|
[p.__class__ for p in dashboard.get_panels()])
|
|
|
|
def test_unregistered_panel_group(self):
|
|
dashboard = horizon.get_dashboard("admin")
|
|
self.assertIsNone(dashboard.get_panel_group("nonexistent_panel"))
|
|
|